Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(118)

Issue 4532064: get tests closer to passing for SKIA_SCALAR=fixed (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 1 month ago by epoger
Modified:
13 years, 1 month ago
Reviewers:
bsalomon, reed1
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

See http://code.google.com/p/skia/issues/detail?id=263 ('fix libskia build for SKIA_SCALAR=fixed') Still doesn't quite pass with SKIA_SCALAR=fixed, but getting closer. To reproduce the build/run: export SKIA_DEBUG=true; export SKIA_SCALAR=fixed ; make clean ; make out/libskia.a ; make tests ; out/tests/tests

Patch Set 1 #

Patch Set 2 : indent fix #

Patch Set 3 : In MatrixTest, note different tolerance for SKIA_SCALAR_IS_FIXED #

Total comments: 4

Patch Set 4 : Mike's suggested changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -25 lines) Patch
M gpu/src/GrPathUtils.cpp View 1 2 3 2 chunks +5 lines, -5 lines 0 comments Download
M include/config/SkUserConfig.h View 2 chunks +1 line, -2 lines 0 comments Download
M src/core/SkScan_Antihair.cpp View 2 chunks +2 lines, -4 lines 0 comments Download
M src/pdf/SkPDFTypes.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/ClipStackTest.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M tests/MatrixTest.cpp View 1 2 3 1 chunk +4 lines, -2 lines 0 comments Download
M tests/PathTest.cpp View 1 2 1 chunk +12 lines, -10 lines 0 comments Download

Messages

Total messages: 8
epoger
13 years, 1 month ago (2011-05-16 21:34:26 UTC) #1
epoger
Ready for review, for reals this time.
13 years, 1 month ago (2011-05-17 14:41:30 UTC) #2
reed1
13 years, 1 month ago (2011-05-17 14:46:45 UTC) #3
reed1
http://codereview.appspot.com/4532064/diff/6001/gpu/src/GrPathUtils.cpp File gpu/src/GrPathUtils.cpp (left): http://codereview.appspot.com/4532064/diff/6001/gpu/src/GrPathUtils.cpp#oldcode72 gpu/src/GrPathUtils.cpp:72: d = ceilf(sqrtf(d/tol)); SkScalarCeil returns an int, not a ...
13 years, 1 month ago (2011-05-17 14:53:08 UTC) #4
epoger
http://codereview.appspot.com/4532064/diff/6001/gpu/src/GrPathUtils.cpp File gpu/src/GrPathUtils.cpp (left): http://codereview.appspot.com/4532064/diff/6001/gpu/src/GrPathUtils.cpp#oldcode72 gpu/src/GrPathUtils.cpp:72: d = ceilf(sqrtf(d/tol)); On 2011/05/17 14:53:08, reed1 wrote: > ...
13 years, 1 month ago (2011-05-17 15:44:29 UTC) #5
epoger
Rookie error: I forgot to rerun upload.py last time.
13 years, 1 month ago (2011-05-17 16:01:47 UTC) #6
reed1
LGTM
13 years, 1 month ago (2011-05-17 16:22:29 UTC) #7
epoger
13 years, 1 month ago (2011-05-17 17:37:44 UTC) #8
committed as r1351
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b