https: correctly handle SSL_WANT_READ conditions

I've got a corresponding changeset for Mercurial if you want to test there, or just apply the diff for http/__init__.py.

https: correctly handle SSL_WANT_READ conditions

This used to break on Python 2.6, and now it won't. The Python 2.4
codepath probably can be cleaned up some, but that can wait until a
future changeset.

tests.util.mocksslwrap now returns a MockSSLSocket, which claims to
require more data from the wire on every other read operation.

REV=b8c3511a8cae

[parren, 2011-05-12 19:36:56]

Works for me.

http://codereview.appspot.com/4532054/diff/1/http/__init__.py
File http/__init__.py (right):

http://codereview.appspot.com/4532054/diff/1/http/__init__.py#newcode554
http/__init__.py:554: try:
SSL_WANT_READ while *sending* data is a bit surprising, but well.

[bboissin, 2011-05-12 19:39:52]

By the way, can there be an issue with WANT_WRITE as well?

Benoit

On Thu, May 12, 2011 at 9:36 PM,  <peter.arrenbrecht@gmail.com> wrote:
> Works for me.
>
>
> http://codereview.appspot.com/4532054/diff/1/http/__init__.py
> File http/__init__.py (right):
>
> http://codereview.appspot.com/4532054/diff/1/http/__init__.py#newcode554
> http/__init__.py:554: try:
> SSL_WANT_READ while *sending* data is a bit surprising, but well.
>
> http://codereview.appspot.com/4532054/
>

[parren, 2011-05-12 19:44:01]

On Thu, May 12, 2011 at 9:39 PM, Benoit Boissinot <bboissin@gmail.com> wrote:
> By the way, can there be an issue with WANT_WRITE as well?

Sounds like it:

http://stackoverflow.com/questions/3952104/how-to-handle-openssl-ssl-error-wa...

-parren

>
> On Thu, May 12, 2011 at 9:36 PM,  <peter.arrenbrecht@gmail.com> wrote:
>> Works for me.
>>
>>
>> http://codereview.appspot.com/4532054/diff/1/http/__init__.py
>> File http/__init__.py (right):
>>
>> http://codereview.appspot.com/4532054/diff/1/http/__init__.py#newcode554
>> http/__init__.py:554: try:
>> SSL_WANT_READ while *sending* data is a bit surprising, but well.
>>
>> http://codereview.appspot.com/4532054/
>>
>

[Augie fackler, 2011-05-12 20:15:21]

On Thu, May 12, 2011 at 2:39 PM, Benoit Boissinot <bboissin@gmail.com> wrote:
> By the way, can there be an issue with WANT_WRITE as well?

hm, presumably. I'll address that in a future patch (probably tonight).

>
> Benoit
>
> On Thu, May 12, 2011 at 9:36 PM,  <peter.arrenbrecht@gmail.com> wrote:
>> Works for me.
>>
>>
>> http://codereview.appspot.com/4532054/diff/1/http/__init__.py
>> File http/__init__.py (right):
>>
>> http://codereview.appspot.com/4532054/diff/1/http/__init__.py#newcode554
>> http/__init__.py:554: try:
>> SSL_WANT_READ while *sending* data is a bit surprising, but well.
>>
>> http://codereview.appspot.com/4532054/
>>
>

[Augie fackler, 2011-05-17 19:19:21]

On May 12, 2011, at 2:43 PM, Peter Arrenbrecht wrote:
> 
> On Thu, May 12, 2011 at 9:39 PM, Benoit Boissinot <bboissin@gmail.com> wrote:
>> By the way, can there be an issue with WANT_WRITE as well?
> 
> Sounds like it:
> 
>
http://stackoverflow.com/questions/3952104/how-to-handle-openssl-ssl-error-wa...

In looking, there's already code to handle that case, which is probably why we
haven't seen it.

> 
> -parren
> 
>> 
>> On Thu, May 12, 2011 at 9:36 PM,  <peter.arrenbrecht@gmail.com> wrote:
>>> Works for me.
>>> 
>>> 
>>> http://codereview.appspot.com/4532054/diff/1/http/__init__.py
>>> File http/__init__.py (right):
>>> 
>>> http://codereview.appspot.com/4532054/diff/1/http/__init__.py#newcode554
>>> http/__init__.py:554: try:
>>> SSL_WANT_READ while *sending* data is a bit surprising, but well.
>>> 
>>> http://codereview.appspot.com/4532054/
>>> 
>>