Issue 4531043: Improve shader generator legibility

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4531043: Improve shader generator legibility (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 4 months ago by bsalomon

Modified:
13 years, 4 months ago

Reviewers:
junov, reed1

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Patch Set 9 : more line wraps #

Total comments: 1

Created: 13 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+371 lines, -423 lines)			Patch
M	gpu/src/GrGLProgram.h	View	1 2 3 4 5 6	6 chunks	+48 lines, -6 lines	0 comments	Download
M	gpu/src/GrGLProgram.cpp	View	1 2 3 4 5 6	18 chunks	+230 lines, -336 lines	1 comment	Download
M	gpu/src/GrGpuGLShaders.cpp	View	1 2 3 4 5 6 7 8	12 chunks	+93 lines, -81 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

junov

I like this change a lot. LGTM. http://codereview.appspot.com/4531043/diff/13004/gpu/src/GrGLProgram.cpp File gpu/src/GrGLProgram.cpp (right): http://codereview.appspot.com/4531043/diff/13004/gpu/src/GrGLProgram.cpp#newcode184 gpu/src/GrGLProgram.cpp:184: #if GR_GL_ATTRIBUTE_MATRICES ...

13 years, 4 months ago (2011-05-09 18:24:50 UTC) #3

bsalomon

Thanks for the review! On Mon, May 9, 2011 at 2:24 PM, <junov@google.com> wrote: > ...

13 years, 4 months ago (2011-05-09 18:31:06 UTC) #4

Closed with r1281

Expand All Messages | Collapse All Messages