Issue 4530066: [PDF] Improve the SkClipStack skipping prefix code.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4530066: [PDF] Improve the SkClipStack skipping prefix code. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 6 months ago by Steve VanDeBogart

Modified:
13 years, 6 months ago

Reviewers:
Chris Guillory

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

Description

[PDF] Improve the SkClipStack skipping prefix code. Because of intersecting done in SkClipStack, we may have to do more work in the last entry of the prefix. Committed: http://code.google.com/p/skia/source/detail?r=1418

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address comments (online & off) #

Created: 13 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -2 lines)			Patch
M	include/core/SkClipStack.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	src/core/SkClipStack.cpp	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
M	src/pdf/SkPDFDevice.cpp	View	1	1 chunk	+20 lines, -2 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Chris Guillory

Draft comment I had before our discussion. http://codereview.appspot.com/4530066/diff/1/src/core/SkClipStack.cpp File src/core/SkClipStack.cpp (right): http://codereview.appspot.com/4530066/diff/1/src/core/SkClipStack.cpp#newcode190 src/core/SkClipStack.cpp:190: bool operator!=(const ...

13 years, 6 months ago (2011-05-25 00:53:51 UTC) #2

Steve VanDeBogart

http://codereview.appspot.com/4530066/diff/1/src/core/SkClipStack.cpp File src/core/SkClipStack.cpp (right): http://codereview.appspot.com/4530066/diff/1/src/core/SkClipStack.cpp#newcode190 src/core/SkClipStack.cpp:190: bool operator!=(const SkClipStack::B2FIter::Clip& a, On 2011/05/25 00:53:51, Chris Guillory ...

13 years, 6 months ago (2011-05-25 01:03:25 UTC) #3

Chris Guillory

13 years, 6 months ago (2011-05-25 01:19:29 UTC) #4

LGTM. Not pretty though. Hopefully as clip stack changes occur this logic can
become cleaner.

Expand All Messages | Collapse All Messages