Issue 4529113: Handle additional lost device error codes that may be returned when using IDi...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4529113: Handle additional lost device error codes that may be returned when using IDi... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 10 months ago by baustin

Modified:
14 years, 10 months ago

Reviewers:
dgkoch

CC:
angleproject-review_googlegroups.com, apatrick1

Base URL:
http://angleproject.googlecode.com/svn/trunk/

Visibility:
Public.

Description

Handle additional lost device error codes that may be returned when using IDirect3DDevice9Ex. Committed: http://code.google.com/p/angleproject/source/detail?r=671

Patch Set 1 #

Created: 14 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/libEGL/Surface.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

dgkoch

(handling this since nicolas is off) According to MSDN those can be returned from Direct3DDevice9Ex::Present ...

14 years, 10 months ago (2011-06-03 22:22:01 UTC) #2

baustin

14 years, 10 months ago (2011-06-03 22:42:08 UTC) #4

On 2011/06/03 22:22:01, dgkoch wrote:
> (handling this since nicolas is off)
> 
> According to MSDN those can be returned from Direct3DDevice9Ex::Present and
> we're calling Direct3D9SwapChain::Present, but MSDN has been wrong before, and
> it can't hurt to check for those here.
> 
> LGTM

I had a case where Present() was returning D3DERR_DEVICEHUNG on my Windows 7
machine, so either MSDN is wrong or there is a bug Direct3D9SwapChain::Present()
(I'm guessing the former).

Expand All Messages | Collapse All Messages