Issue 4529103: Send the new capabilities to ibus-daemon in ibus_im_context_set_use_preedit.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4529103: Send the new capabilities to ibus-daemon in ibus_im_context_set_use_preedit. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 11 months ago by Yusuke Sato

Modified:
12 years, 11 months ago

Reviewers:
shawn.p.huang, Peng Huang

CC:
kinaba, kochi

Base URL:
git@github.com:ibus/ibus.git@master

Visibility:
Public.

Description

Send the new capabilities to ibus-daemon in ibus_im_context_set_use_preedit. BUG=none TEST=none

Patch Set 1 #

Total comments: 2

Created: 12 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	client/gtk2/ibusimcontext.c	View		1 chunk	+1 line, -0 lines	2 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Yusuke Sato

Peng: Please review the change. kinaba: Could you test the change?

12 years, 11 months ago (2011-06-01 04:18:10 UTC) #1

Peng

LGTM http://codereview.appspot.com/4529103/diff/1/client/gtk2/ibusimcontext.c File client/gtk2/ibusimcontext.c (right): http://codereview.appspot.com/4529103/diff/1/client/gtk2/ibusimcontext.c#newcode945 client/gtk2/ibusimcontext.c:945: ibus_input_context_set_capabilities (ibusimcontext->ibuscontext, ibusimcontext->caps); this line is little long.

12 years, 11 months ago (2011-06-01 13:10:53 UTC) #3

Yusuke Sato

12 years, 11 months ago (2011-06-01 14:37:10 UTC) #4

http://codereview.appspot.com/4529103/diff/1/client/gtk2/ibusimcontext.c
File client/gtk2/ibusimcontext.c (right):

http://codereview.appspot.com/4529103/diff/1/client/gtk2/ibusimcontext.c#newc...
client/gtk2/ibusimcontext.c:945: ibus_input_context_set_capabilities
(ibusimcontext->ibuscontext, ibusimcontext->caps);
On 2011/06/01 13:10:53, Peng wrote:
> this line is little long.

Done.

Expand All Messages | Collapse All Messages