Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(275)

Issue 4529096: Fix for issue 198: User input should be saved after an "invalid XSRF token" error (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 11 months ago by techtonik
Modified:
12 years, 10 months ago
Reviewers:
Andi Albrecht
CC:
codereview-discuss_googlegroups.com
Base URL:
http://rietveld.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Don't pay attention at app.yaml, the test server is live at http://60.retreview.appspot.com/2/ The fix is to have <textarea> field attached to every reply. Then browser can identify these <textarea>s and autofill them with saved values after going back from next page. We do not output forms for every reply link, but generate forms dynamically. I assume it's done to save some space on page load. This fix moves <textarea> that is already available on the page for the given reply link into generated form. The fix works in Chrome and doesn't work in FF5 Beta. FF5 seems to lose connection from original <textarea> to moved node. Mozilla bug opened: https://bugzilla.mozilla.org/show_bug.cgi?id=660549

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -10 lines) Patch
M app.yaml View 1 chunk +2 lines, -2 lines 0 comments Download
M static/script.js View 1 chunk +14 lines, -5 lines 0 comments Download
M templates/issue.html View 2 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 5
techtonik
12 years, 11 months ago (2011-05-29 19:02:41 UTC) #1
Andi Albrecht
The idea is to have a textarea for each message instead of always cloning it? ...
12 years, 11 months ago (2011-05-31 20:41:34 UTC) #2
techtonik
To test it - just write reply to the message and then click any link ...
12 years, 11 months ago (2011-05-31 20:51:00 UTC) #3
Andi Albrecht
LGTM To me it looks a bit fragile how the JS works since it heavily ...
12 years, 10 months ago (2011-06-01 19:33:34 UTC) #4
techtonik
12 years, 10 months ago (2011-06-02 10:04:09 UTC) #5
Thanks. Committed in r756. I've increased version number to test this fix with
other browsers.

To make our app less fragile, we can switch to using selectors with Sizzle
library.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b