Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(115)

Issue 4528112: Add gyp for bench and make run on Windows. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 7 months ago by bungeman
Modified:
13 years, 7 months ago
Reviewers:
epoger
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Patch Set 1 #

Total comments: 5

Patch Set 2 : Now less filling. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -0 lines) Patch
A gyp/bench.gyp View 1 1 chunk +55 lines, -0 lines 0 comments Download
M gyp/core.gyp View 2 chunks +2 lines, -0 lines 0 comments Download
M include/utils/SkEGLContext.h View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 6
bungeman
13 years, 7 months ago (2011-05-31 19:52:20 UTC) #1
epoger
http://codereview.appspot.com/4528112/diff/1/gyp/bench.gyp File gyp/bench.gyp (right): http://codereview.appspot.com/4528112/diff/1/gyp/bench.gyp#newcode9 gyp/bench.gyp:9: 'mac_bundle' : 1, I would take out the mac_bundle ...
13 years, 7 months ago (2011-05-31 20:18:02 UTC) #2
bungeman
13 years, 7 months ago (2011-05-31 20:46:18 UTC) #3
epoger
LGTM
13 years, 7 months ago (2011-05-31 20:50:13 UTC) #4
bungeman
Committed revision 1458.
13 years, 7 months ago (2011-05-31 21:22:46 UTC) #5
bungeman
13 years, 7 months ago (2011-05-31 21:23:45 UTC) #6

          
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b