Issue 4527092: New Sample Tests

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4527092: New Sample Tests (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 7 months ago by yangsu

Modified:
13 years, 7 months ago

Reviewers:
reed1

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Patch Set 1 #

Total comments: 6

Patch Set 2 : Fixed includes and removed BUILD FOR WIN code #

Patch Set 3 : Updated samples to send title directly #

Created: 13 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+194 lines, -0 lines)			Patch
A	samplecode/SampleAnimatedGradient.cpp	View	1 2	1 chunk	+90 lines, -0 lines	0 comments	Download
A	samplecode/SampleBox.cpp	View	1 2	1 chunk	+48 lines, -0 lines	0 comments	Download
A	samplecode/SampleSpiral.cpp	View	1 2	1 chunk	+56 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

reed1

Lets try to remove any of the superfluous code that came from the copy/paste (including ...

13 years, 7 months ago (2011-06-01 14:45:47 UTC) #2

yangsu

13 years, 7 months ago (2011-06-01 15:47:45 UTC) #3

http://codereview.appspot.com/4527092/diff/1/samplecode/SampleAnimatedGradien...
File samplecode/SampleAnimatedGradient.cpp (right):

http://codereview.appspot.com/4527092/diff/1/samplecode/SampleAnimatedGradien...
samplecode/SampleAnimatedGradient.cpp:35: 
On 2011/06/01 14:45:47, reed1 wrote:
> Can you safely remove the SK_BUILD_FOR_WIN lines above, and the text below?

Done.

http://codereview.appspot.com/4527092/diff/1/samplecode/SampleBox.cpp
File samplecode/SampleBox.cpp (right):

http://codereview.appspot.com/4527092/diff/1/samplecode/SampleBox.cpp#newcode54
samplecode/SampleBox.cpp:54: SkString str("Simple");
On 2011/06/01 14:45:47, reed1 wrote:
> Got a better name for the title/subclass?

Done.

http://codereview.appspot.com/4527092/diff/1/samplecode/SampleSpiral.cpp
File samplecode/SampleSpiral.cpp (right):

http://codereview.appspot.com/4527092/diff/1/samplecode/SampleSpiral.cpp#newc...
samplecode/SampleSpiral.cpp:36: #ifdef SK_BUILD_FOR_WIN
On 2011/06/01 14:45:47, reed1 wrote:
> kill this WIN code?

Done.

Expand All Messages | Collapse All Messages