Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(205)

Issue 4527084: split skia.gyp into separate gypfile for each source dir (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 6 months ago by epoger
Modified:
13 years, 6 months ago
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

The single skia.gyp file was getting pretty unwieldy (1600 lines long), so this CL splits it into a separate gypfile for each source directory (analogous to how our makefiles are set up currently). Ultimately, I think it would be better to maintain each gypfile within the same directory where the source code lives (like we do with the makefiles), but I had some trouble building when I did that... so for this CL, I kept them all in the same directory. I'll try to move them later.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -22350 lines) Patch
A + gyp/SampleApp.gyp View 3 chunks +14 lines, -1450 lines 0 comments Download
A + gyp/animator.gyp View 2 chunks +3 lines, -1415 lines 0 comments Download
A + gyp/effects.gyp View 2 chunks +3 lines, -1525 lines 0 comments Download
A + gyp/experimental.gyp View 2 chunks +3 lines, -1571 lines 0 comments Download
A + gyp/gpu.gyp View 3 chunks +4 lines, -1324 lines 0 comments Download
A + gyp/images.gyp View 2 chunks +3 lines, -1504 lines 0 comments Download
A + gyp/libtess.gyp View 1 chunk +3 lines, -1556 lines 0 comments Download
A + gyp/opts.gyp View 3 chunks +4 lines, -1557 lines 0 comments Download
A + gyp/pdf.gyp View 2 chunks +3 lines, -1553 lines 0 comments Download
M gyp/skia.gyp View 2 chunks +4 lines, -1281 lines 0 comments Download
A + gyp/svg.gyp View 2 chunks +3 lines, -1517 lines 0 comments Download
A + gyp/target_defaults.gypi View 1 chunk +0 lines, -1543 lines 0 comments Download
A + gyp/utils.gyp View 2 chunks +3 lines, -1518 lines 0 comments Download
A + gyp/views.gyp View 2 chunks +3 lines, -1486 lines 0 comments Download
A + gyp/xml.gyp View 2 chunks +3 lines, -1550 lines 0 comments Download

Messages

Total messages: 9
epoger
13 years, 6 months ago (2011-05-27 22:11:53 UTC) #1
bsalomon
On 2011/05/27 22:11:53, epoger wrote: LGTM
13 years, 6 months ago (2011-05-29 19:53:31 UTC) #2
reed1
LGTM
13 years, 6 months ago (2011-05-31 13:10:01 UTC) #3
epoger
committed as r1446
13 years, 6 months ago (2011-05-31 13:51:51 UTC) #4
Stephen White
On 2011/05/31 13:51:51, epoger wrote: > committed as r1446 "rm -rf Makefile *mk *.Makefile out ...
13 years, 6 months ago (2011-05-31 18:11:01 UTC) #5
Stephen White
On 2011/05/31 13:51:51, epoger wrote: > committed as r1446 "rm -rf Makefile *mk *.Makefile out ...
13 years, 6 months ago (2011-05-31 18:11:02 UTC) #6
epoger
On 2011/05/31 18:11:02, Stephen White wrote: > On 2011/05/31 13:51:51, epoger wrote: > > committed ...
13 years, 6 months ago (2011-05-31 18:20:45 UTC) #7
Stephen White
My point is, this used to work before this change: ./gyp_skia make SampleApp Now it ...
13 years, 6 months ago (2011-05-31 18:28:10 UTC) #8
epoger
13 years, 6 months ago (2011-05-31 18:29:57 UTC) #9
On 2011/05/31 18:28:10, Stephen White wrote:
> My point is, this used to work before this change:
> 
> ./gyp_skia
> make SampleApp
> 
> Now it doesn't.

That's not good.  I will fix it ASAP.  Sorry for the inconvenience.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b