[PDF] Don't draw empty layers.

[PDF] Don't draw empty layers.

Committed: http://code.google.com/p/skia/source/detail?r=1410

[Chris Guillory, 2011-05-23 23:52:11]

LGTM

http://codereview.appspot.com/4527072/diff/1/src/pdf/SkPDFDevice.cpp
File src/pdf/SkPDFDevice.cpp (right):

http://codereview.appspot.com/4527072/diff/1/src/pdf/SkPDFDevice.cpp#newcode912
src/pdf/SkPDFDevice.cpp:912: return;
Nit: Comment why we don't need to draw because the device's content is empty.

[Steve VanDeBogart, 2011-05-24 06:43:32]

http://codereview.appspot.com/4527072/diff/1/src/pdf/SkPDFDevice.cpp
File src/pdf/SkPDFDevice.cpp (right):

http://codereview.appspot.com/4527072/diff/1/src/pdf/SkPDFDevice.cpp#newcode912
src/pdf/SkPDFDevice.cpp:912: return;
On 2011/05/23 23:52:11, Chris Guillory wrote:
> Nit: Comment why we don't need to draw because the device's content is empty.

I don't think such a comment would add any value. The Google style guide
specifically notes that you shouldn't use comments that restate (non-tricky)
code.

[Chris Guillory, 2011-05-24 09:18:48]

On 2011/05/24 06:43:32, Steve VanDeBogart wrote:
> http://codereview.appspot.com/4527072/diff/1/src/pdf/SkPDFDevice.cpp
> File src/pdf/SkPDFDevice.cpp (right):
> 
>
http://codereview.appspot.com/4527072/diff/1/src/pdf/SkPDFDevice.cpp#newcode912
> src/pdf/SkPDFDevice.cpp:912: return;
> On 2011/05/23 23:52:11, Chris Guillory wrote:
> > Nit: Comment why we don't need to draw because the device's content is
empty.
> 
> I don't think such a comment would add any value. The Google style guide
> specifically notes that you shouldn't use comments that restate (non-tricky)
> code.
We definitely don't need a comment here since this can be updated to make use of
the new isContentEmpty() member function.

[Chris Guillory, 2011-05-24 09:18:57]

LGTM