Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(122)

Issue 4527072: [PDF] Don't draw empty layers. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 5 months ago by Steve VanDeBogart
Modified:
13 years, 5 months ago
Reviewers:
Chris Guillory
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlecode.com/svn/trunk
Visibility:
Public.

Description

[PDF] Don't draw empty layers. Committed: http://code.google.com/p/skia/source/detail?r=1410

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M src/pdf/SkPDFDevice.cpp View 2 chunks +7 lines, -2 lines 2 comments Download

Messages

Total messages: 5
Steve VanDeBogart
13 years, 5 months ago (2011-05-23 06:28:37 UTC) #1
Chris Guillory
LGTM http://codereview.appspot.com/4527072/diff/1/src/pdf/SkPDFDevice.cpp File src/pdf/SkPDFDevice.cpp (right): http://codereview.appspot.com/4527072/diff/1/src/pdf/SkPDFDevice.cpp#newcode912 src/pdf/SkPDFDevice.cpp:912: return; Nit: Comment why we don't need to ...
13 years, 5 months ago (2011-05-23 23:52:11 UTC) #2
Steve VanDeBogart
http://codereview.appspot.com/4527072/diff/1/src/pdf/SkPDFDevice.cpp File src/pdf/SkPDFDevice.cpp (right): http://codereview.appspot.com/4527072/diff/1/src/pdf/SkPDFDevice.cpp#newcode912 src/pdf/SkPDFDevice.cpp:912: return; On 2011/05/23 23:52:11, Chris Guillory wrote: > Nit: ...
13 years, 5 months ago (2011-05-24 06:43:32 UTC) #3
Chris Guillory
On 2011/05/24 06:43:32, Steve VanDeBogart wrote: > http://codereview.appspot.com/4527072/diff/1/src/pdf/SkPDFDevice.cpp > File src/pdf/SkPDFDevice.cpp (right): > > http://codereview.appspot.com/4527072/diff/1/src/pdf/SkPDFDevice.cpp#newcode912 ...
13 years, 5 months ago (2011-05-24 09:18:48 UTC) #4
Chris Guillory
13 years, 5 months ago (2011-05-24 09:18:57 UTC) #5
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b