Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(21)

Issue 4526088: Add more SK_API declarations to fix Chrome. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 6 months ago by Steve VanDeBogart
Modified:
13 years, 6 months ago
Reviewers:
Chris Guillory, reed1
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlecode.com/svn/trunk
Visibility:
Public.

Description

Add more SK_API declarations to fix Chrome. TBR=ctguil@chromium.org

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -14 lines) Patch
M include/pdf/SkPDFDevice.h View 1 chunk +8 lines, -6 lines 0 comments Download
M include/pdf/SkPDFFont.h View 3 chunks +9 lines, -8 lines 0 comments Download

Messages

Total messages: 5
Steve VanDeBogart
13 years, 6 months ago (2011-05-30 20:52:19 UTC) #1
reed1
Can we not just put SK_API on the class definition line, instead of on each ...
13 years, 6 months ago (2011-05-31 12:08:30 UTC) #2
Steve VanDeBogart
There's a problem adding it to the class if there are templatized fields, or something ...
13 years, 6 months ago (2011-05-31 15:26:45 UTC) #3
reed1
Templates are just awesome! On Tue, May 31, 2011 at 11:26 AM, Steve VanDeBogart <vandebo@chromium.org> ...
13 years, 6 months ago (2011-05-31 15:40:03 UTC) #4
Chris Guillory
13 years, 6 months ago (2011-05-31 17:19:51 UTC) #5
LGTM.

If we put SK_API on the class we would need to export all of its members. For
the template members that includes specifically exporting the definitions for
the template instantiations that are used. It is possible to do that.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b