There's a problem adding it to the class if there are templatized fields, or something ...
13 years, 6 months ago
(2011-05-31 15:26:45 UTC)
#3
There's a problem adding it to the class if there are templatized fields, or
something like that. Chris knows the details.
--
Steve
On Tue, May 31, 2011 at 5:08 AM, <reed@google.com> wrote:
> Can we not just put SK_API on the class definition line, instead of on
> each method?
>
>
> http://codereview.appspot.com/4526088/
>
Templates are just awesome! On Tue, May 31, 2011 at 11:26 AM, Steve VanDeBogart <vandebo@chromium.org> ...
13 years, 6 months ago
(2011-05-31 15:40:03 UTC)
#4
Templates are just awesome!
On Tue, May 31, 2011 at 11:26 AM, Steve VanDeBogart
<vandebo@chromium.org> wrote:
> There's a problem adding it to the class if there are templatized fields, or
> something like that. Chris knows the details.
> --
> Steve
>
> On Tue, May 31, 2011 at 5:08 AM, <reed@google.com> wrote:
>>
>> Can we not just put SK_API on the class definition line, instead of on
>> each method?
>>
>> http://codereview.appspot.com/4526088/
>
>
LGTM. If we put SK_API on the class we would need to export all of ...
13 years, 6 months ago
(2011-05-31 17:19:51 UTC)
#5
LGTM.
If we put SK_API on the class we would need to export all of its members. For
the template members that includes specifically exporting the definitions for
the template instantiations that are used. It is possible to do that.
Issue 4526088: Add more SK_API declarations to fix Chrome.
(Closed)
Created 13 years, 6 months ago by Steve VanDeBogart
Modified 13 years, 6 months ago
Reviewers: Chris Guillory, reed1
Base URL: https://skia.googlecode.com/svn/trunk
Comments: 0