Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1033)

Issue 4526051: Disable blend for edge AA, not general AA (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 6 months ago by bsalomon
Modified:
13 years, 6 months ago
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Blending was being turned off for smooth lines, so didn't affect Chrome.

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M gpu/src/GrDrawTarget.cpp View 1 chunk +1 line, -1 line 1 comment Download

Messages

Total messages: 3
bsalomon
A side effect of returning false in canDisableBlend is that we can't use smooth lines: ...
13 years, 6 months ago (2011-05-12 20:24:32 UTC) #1
Stephen White
LGTM. Thanks! http://codereview.appspot.com/4526051/diff/1/gpu/src/GrDrawTarget.cpp File gpu/src/GrDrawTarget.cpp (right): http://codereview.appspot.com/4526051/diff/1/gpu/src/GrDrawTarget.cpp#newcode482 gpu/src/GrDrawTarget.cpp:482: if (fCurrDrawState.fFlagBits & kEdgeAA_StateBit) { Argh, sorry. ...
13 years, 6 months ago (2011-05-12 20:28:53 UTC) #2
bsalomon
13 years, 6 months ago (2011-05-12 20:35:10 UTC) #3
On 2011/05/12 20:28:53, Stephen White wrote:
> LGTM.  Thanks!
> 
> http://codereview.appspot.com/4526051/diff/1/gpu/src/GrDrawTarget.cpp
> File gpu/src/GrDrawTarget.cpp (right):
> 
>
http://codereview.appspot.com/4526051/diff/1/gpu/src/GrDrawTarget.cpp#newcode482
> gpu/src/GrDrawTarget.cpp:482: if (fCurrDrawState.fFlagBits & kEdgeAA_StateBit)
{
> Argh, sorry.  That's what this code should've been in the first place.


np, I forgot about that side-effect. Checked in at r1316.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b