Issue 4523056: Keep program cache in a consistent state when program creation fails

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4523056: Keep program cache in a consistent state when program creation fails (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 8 months ago by bsalomon

Modified:
13 years, 8 months ago

Reviewers:
junov, junov1, reed1

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Patch Set 2 : remove debug code #

Total comments: 1

Created: 13 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -11 lines)			Patch
	M	gpu/src/GrGLProgram.h	View		1 chunk	+1 line, -1 line	1 comment	Download
	M	gpu/src/GrGpuGLShaders.cpp	View		4 chunks	+11 lines, -10 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

bsalomon

This makes a copy of a GrGLProgram::CachedData but only when we're in the midst of ...

13 years, 8 months ago (2011-05-11 14:07:19 UTC) #1

junov1

Looks good. http://codereview.appspot.com/4523056/diff/2001/gpu/src/GrGLProgram.h File gpu/src/GrGLProgram.h (right): http://codereview.appspot.com/4523056/diff/2001/gpu/src/GrGLProgram.h#newcode184 gpu/src/GrGLProgram.h:184: memcpy(this, &other, sizeof(CachedData)); Nit: sizeof(*this)

13 years, 8 months ago (2011-05-11 15:22:16 UTC) #2

Fixed with r1298

Expand All Messages | Collapse All Messages