Keyboard Shortcuts
File
u
:
up to issue
m
:
publish + mail comments
M
:
edit review message
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
<Enter>
:
respond to / edit current comment
d
:
mark current comment as done
Issue
u
:
up to list of issues
m
:
publish + mail comments
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
#
:
close issue
Comment/message editing
<Ctrl>
+
s
or
<Ctrl>
+
Enter
:
save comment
<Esc>
:
cancel edit
Rietveld
Code Review Tool
Help
|
Bug tracker
|
Discussion group
|
Source code
|
Sign in
(1159)
Issues
Repositories
Search
Open Issues
|
Closed Issues
|
All Issues
|
Sign in
with your
Google Account
to create issues and add comments
Issue
4523046
: Share SkRect, using GrRect as an alias (Closed)
Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 8 months ago by
reed1
Modified:
13 years, 3 months ago
Reviewers:
bsalomon
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.
Patch Set 1
#
Patch Set 2 : delete #if 0 code
#
Created:
13 years, 8 months ago
Download
[raw]
[tar.bz2]
Unified diffs
Side-by-side diffs
Delta from patch set
Stats
(
+149 lines, -549 lines
)
Patch
M
gpu/include/GrMatrix.h
View
1 chunk
+1 line, -3 lines
0 comments
Download
M
gpu/include/GrPathIter.h
View
1 chunk
+1 line, -3 lines
0 comments
Download
M
gpu/include/GrRect.h
View
1
1 chunk
+9 lines, -450 lines
0 comments
Download
M
gpu/src/GrClip.cpp
View
1
2 chunks
+7 lines, -1 line
0 comments
Download
M
gpu/src/GrContext.cpp
View
7 chunks
+19 lines, -12 lines
0 comments
Download
M
gpu/src/GrGpu.cpp
View
1 chunk
+3 lines, -1 line
0 comments
Download
M
gpu/src/GrGpuGL.cpp
View
1 chunk
+3 lines, -4 lines
0 comments
Download
M
gpu/src/GrMatrix.cpp
View
1 chunk
+0 lines, -30 lines
0 comments
Download
M
gpu/src/GrPath.cpp
View
1
7 chunks
+16 lines, -9 lines
0 comments
Download
M
gpu/src/GrTexture.cpp
View
2 chunks
+5 lines, -3 lines
0 comments
Download
M
include/core/SkRect.h
View
9 chunks
+70 lines, -1 line
0 comments
Download
M
include/gpu/SkGr.h
View
1
2 chunks
+1 line, -20 lines
0 comments
Download
M
src/gpu/SkGpuDevice.cpp
View
1
4 chunks
+13 lines, -11 lines
0 comments
Download
M
src/gpu/SkGr.cpp
View
1
1 chunk
+1 line, -1 line
0 comments
Download
Messages
Total messages: 2
Expand All Messages
|
Collapse All Messages
reed1
13 years, 8 months ago (2011-05-09 15:44:36 UTC)
#1
Sign in
to reply to this message.
bsalomon
LGrrrrrrrrrrrreatTM On 2011/05/09 15:44:36, reed1 wrote:
13 years, 8 months ago (2011-05-09 16:57:30 UTC)
#2
LGrrrrrrrrrrrreatTM On 2011/05/09 15:44:36, reed1 wrote:
Sign in
to reply to this message.
Expand All Messages
|
Collapse All Messages
Issue 4523046: Share SkRect, using GrRect as an alias (Closed)
Created 13 years, 8 months ago by reed1
Modified 13 years, 3 months ago
Reviewers: bsalomon
Base URL: http://skia.googlecode.com/svn/trunk/
Comments: 0
Recent Issues
|
This issue
This is Rietveld
f62528b