Add in support for 2LO

Add in support for 2LO

[aiuto, 2011-05-23 14:38:34]

http://codereview.appspot.com/4517087/diff/1/apiclient/oauth.py
File apiclient/oauth.py (right):

http://codereview.appspot.com/4517087/diff/1/apiclient/oauth.py#newcode236
apiclient/oauth.py:236: 
one too many blank lines.

http://codereview.appspot.com/4517087/diff/1/apiclient/oauth.py#newcode238
apiclient/oauth.py:238: class TwoLeggedOAuthCredentials(Credentials):
This is clearly cut and pasted from the other Auth helper.
Do you want to abstract out the commonality? Or not?
If so, I'm happy to look at it here, or in a separate CL.

http://codereview.appspot.com/4517087/diff/1/apiclient/oauth.py#newcode241
apiclient/oauth.py:241: The Two Legged object is created directly, not from a
flow.
Is this wrapped for 80 columns?

http://codereview.appspot.com/4517087/diff/1/apiclient/oauth.py#newcode246
apiclient/oauth.py:246: 
too many blanks?

http://codereview.appspot.com/4517087/diff/1/apiclient/oauth.py#newcode252
apiclient/oauth.py:252: credentials.requestor = 'bar@example.info'
Does this work?  Or do you have to say
credentials.setrequstor('bar@exmaple.info')

http://codereview.appspot.com/4517087/diff/1/apiclient/oauth.py#newcode310
apiclient/oauth.py:310: """
Need a comment here.

http://codereview.appspot.com/4517087/diff/1/tests/test_oauth.py
File tests/test_oauth.py (right):

http://codereview.appspot.com/4517087/diff/1/tests/test_oauth.py#newcode72
tests/test_oauth.py:72:
self.assertEqual('http://example.com?xoauth_requestor_id=test%40example.org',
content)
line length

[jcgregorio, 2011-05-24 18:29:46]

http://codereview.appspot.com/4517087/diff/1/apiclient/oauth.py
File apiclient/oauth.py (right):

http://codereview.appspot.com/4517087/diff/1/apiclient/oauth.py#newcode236
apiclient/oauth.py:236: 
On 2011/05/23 14:38:34, aiuto wrote:
> one too many blank lines.

Done.

http://codereview.appspot.com/4517087/diff/1/apiclient/oauth.py#newcode238
apiclient/oauth.py:238: class TwoLeggedOAuthCredentials(Credentials):
Separate CL.

On 2011/05/23 14:38:34, aiuto wrote:
> This is clearly cut and pasted from the other Auth helper.
> Do you want to abstract out the commonality? Or not?
> If so, I'm happy to look at it here, or in a separate CL.

http://codereview.appspot.com/4517087/diff/1/apiclient/oauth.py#newcode241
apiclient/oauth.py:241: The Two Legged object is created directly, not from a
flow.
On 2011/05/23 14:38:34, aiuto wrote:
> Is this wrapped for 80 columns?

Done.

http://codereview.appspot.com/4517087/diff/1/apiclient/oauth.py#newcode246
apiclient/oauth.py:246: 
On 2011/05/23 14:38:34, aiuto wrote:
> too many blanks?

Done.

http://codereview.appspot.com/4517087/diff/1/apiclient/oauth.py#newcode252
apiclient/oauth.py:252: credentials.requestor = 'bar@example.info'
On 2011/05/23 14:38:34, aiuto wrote:
> Does this work?  Or do you have to say
> credentials.setrequstor('bar@exmaple.info')

It's credentials.requestor = 'bar@exmaple.info'

See below where I have 'requestor = @property(...'

http://codereview.appspot.com/4517087/diff/1/apiclient/oauth.py#newcode310
apiclient/oauth.py:310: """
On 2011/05/23 14:38:34, aiuto wrote:
> Need a comment here.

Done.

http://codereview.appspot.com/4517087/diff/1/tests/test_oauth.py
File tests/test_oauth.py (right):

http://codereview.appspot.com/4517087/diff/1/tests/test_oauth.py#newcode72
tests/test_oauth.py:72:
self.assertEqual('http://example.com?xoauth_requestor_id=test%40example.org',
content)
On 2011/05/23 14:38:34, aiuto wrote:
> line length

Done.

[aiuto, 2011-05-24 19:26:34]

lgtm

http://codereview.appspot.com/4517087/diff/1/apiclient/oauth.py
File apiclient/oauth.py (right):

http://codereview.appspot.com/4517087/diff/1/apiclient/oauth.py#newcode252
apiclient/oauth.py:252: credentials.requestor = 'bar@example.info'
On 2011/05/24 18:29:46, jcgregorio wrote:
> On 2011/05/23 14:38:34, aiuto wrote:
> > Does this work?  Or do you have to say
> > credentials.setrequstor('bar@exmaple.info')
> 
> It's credentials.requestor = 'bar@exmaple.info'
> 
> See below where I have 'requestor = @property(...'

Duh.  I was looking for an @property above the field, not in that syntax.