Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2509)

Issue 4517086: Plug a leak in SampleShaderText (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 1 month ago by Stephen White
Modified:
13 years, 1 month ago
Reviewers:
reed, bsalomon
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Make this sample valgrind-friendly.

Patch Set 1 #

Patch Set 2 : Remove inadvertently-added file #

Total comments: 1

Patch Set 3 : Alternate fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
samplecode/SampleShaderText.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7
Stephen White
13 years, 1 month ago (2011-05-19 17:14:30 UTC) #1
Stephen White
Remove inadvertently-added file
13 years, 1 month ago (2011-05-19 17:15:41 UTC) #2
bsalomon
LGTM http://codereview.appspot.com/4517086/diff/2001/samplecode/SampleShaderText.cpp File samplecode/SampleShaderText.cpp (left): http://codereview.appspot.com/4517086/diff/2001/samplecode/SampleShaderText.cpp#oldcode177 samplecode/SampleShaderText.cpp:177: paint.setShader(shaders[s])->ref(); It should have been unref() rather than ...
13 years, 1 month ago (2011-05-19 17:27:19 UTC) #3
Stephen White
On 2011/05/19 17:27:19, bsalomon wrote: > LGTM > > http://codereview.appspot.com/4517086/diff/2001/samplecode/SampleShaderText.cpp > File samplecode/SampleShaderText.cpp (left): > ...
13 years, 1 month ago (2011-05-19 17:43:37 UTC) #4
Stephen White
Alternate fix
13 years, 1 month ago (2011-05-19 17:43:50 UTC) #5
bsalomon
LGTM On 2011/05/19 17:43:50, Stephen White wrote: > Alternate fix
13 years, 1 month ago (2011-05-19 18:19:27 UTC) #6
Stephen White
13 years, 1 month ago (2011-05-19 18:36:58 UTC) #7
Landed as r1384, closing.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b