Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1193)

Issue 4517051: Better width functions for the current arpeggio print functions. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 10 months ago by MikeSol
Modified:
12 years, 9 months ago
Reviewers:
mike, carl.d.sorensen, Neil Puttock
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Better width functions for the current arpeggio print functions.

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -2 lines) Patch
M lily/arpeggio.cc View 4 chunks +56 lines, -2 lines 1 comment Download
M lily/include/arpeggio.hh View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 8
MikeSol
I had added a Rietveld issue about this, but the example on my Rietveld issue ...
12 years, 10 months ago (2011-05-11 02:10:31 UTC) #1
Carl
Seems reasonable to me. I couldn't think of any way to generalize the internal call. ...
12 years, 10 months ago (2011-05-11 13:51:28 UTC) #2
mike_apollinemike.com
On May 11, 2011, at 9:51 AM, Carl.D.Sorensen@gmail.com wrote: > Seems reasonable to me. > ...
12 years, 10 months ago (2011-05-11 14:18:50 UTC) #3
Neil Puttock
On 11 May 2011 15:18, mike@apollinemike.com <mike@apollinemike.com> wrote: > There is a note in arpeggio.cc ...
12 years, 10 months ago (2011-05-11 16:01:36 UTC) #4
Neil Puttock
http://codereview.appspot.com/4517051/diff/1/lily/arpeggio.cc File lily/arpeggio.cc (right): http://codereview.appspot.com/4517051/diff/1/lily/arpeggio.cc#newcode98 lily/arpeggio.cc:98: MAKE_SCHEME_CALLBACK (Arpeggio, internal_print, 1); Why are you exporting these ...
12 years, 10 months ago (2011-05-11 16:02:26 UTC) #5
mike_apollinemike.com
On May 11, 2011, at 12:02 PM, n.puttock@gmail.com wrote: > > http://codereview.appspot.com/4517051/diff/1/lily/arpeggio.cc > File lily/arpeggio.cc ...
12 years, 10 months ago (2011-05-11 18:11:32 UTC) #6
Neil Puttock
On 11 May 2011 19:11, <mike@apollinemike.com> wrote: > The issue is that, for the chord ...
12 years, 10 months ago (2011-05-11 18:19:10 UTC) #7
mike_apollinemike.com
12 years, 10 months ago (2011-05-11 18:35:40 UTC) #8
On May 11, 2011, at 2:19 PM, Neil Puttock wrote:

> On 11 May 2011 19:11,  <mike@apollinemike.com> wrote:
> 
>> The issue is that, for the chord bracket and chord slur (and Bertrand's
eventual chord brace, which hypothetically varies significantly in its X
dimension as it gets larger), the width of the grob is dependent on knowing the
extremal note head positions, which triggers a vertical alignment.
> 
> Surely not the chord bracket?  It has a fixed width (line 171 of
> arpeggio.cc), though perhaps it should be tweakable.
> 

Sorry - yes, you're right.  I amend my comment to chord slurs and braces.

>> Any suggestions on how to get this information without triggering the
vertical alignment?
> 
> Sorry, no.
> 

I'll try to think of something...

~Mike
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b