Issue 4515195: Drop use of @login_decorator since it can only be used on GET requests.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4515195: Drop use of @login_decorator since it can only be used on GET requests. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 1 month ago by jcgregorio_google

Modified:
14 years ago

Reviewers:
jcgregorio_google, ade

CC:
google-api-python-client_googlegroups.com

Visibility:
Public.

Patch Set 1 #

Patch Set 2 : fixed 80 chars #

Total comments: 1

Created: 14 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -4 lines)			Patch
	M	oauth2client/appengine.py	View	1	2 chunks	+10 lines, -4 lines	1 comment	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

ade

14 years ago (2011-06-12 16:04:38 UTC) #2

http://codereview.appspot.com/4515195/diff/2001/oauth2client/appengine.py
File oauth2client/appengine.py (left):

http://codereview.appspot.com/4515195/diff/2001/oauth2client/appengine.py#old...
oauth2client/appengine.py:224: def check_oauth(request_handler, *args):
Can you add a comment to the sections of duplicated code explaining that we're
not using the login_required decorator because we need to support POST requests.

Expand All Messages | Collapse All Messages