Issue 4515144: Add preliminary support for uploading media.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4515144: Add preliminary support for uploading media. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 4 months ago by jcgregorio

Modified:
13 years, 4 months ago

Reviewers:
jcgregorio_google, joe, ade

CC:
google-api-python-client_googlegroups.com

Visibility:
Public.

Patch Set 2 : removed dup test #

Total comments: 1

Created: 13 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+89 lines, -12 lines)			Patch
M	apiclient/discovery.py	View		6 chunks	+62 lines, -12 lines	1 comment	Download
M	apiclient/errors.py	View		1 chunk	+5 lines, -0 lines	0 comments	Download
A	tests/data/smiley.png	View		Binary file		0 comments	Download
M	tests/test_discovery.py	View	1	1 chunk	+22 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

ade

LGTM apart from the potential Buzz breakage. http://codereview.appspot.com/4515144/diff/3001/apiclient/discovery.py File apiclient/discovery.py (right): http://codereview.appspot.com/4515144/diff/3001/apiclient/discovery.py#newcode350 apiclient/discovery.py:350: expanded_url = ...

13 years, 4 months ago (2011-05-27 00:08:52 UTC) #2

joe_bitworking.org

13 years, 4 months ago (2011-05-27 00:36:05 UTC) #3

That should have been fixed a long time ago, is there a path that looks like
it won't work?

On Thu, May 26, 2011 at 8:08 PM,  <ade@google.com> wrote:
> LGTM apart from the potential Buzz breakage.
>
>
> http://codereview.appspot.com/4515144/diff/3001/apiclient/discovery.py
> File apiclient/discovery.py (right):
>
>
http://codereview.appspot.com/4515144/diff/3001/apiclient/discovery.py#newcod...
> apiclient/discovery.py:350: expanded_url = uritemplate.expand(pathUrl,
> params)
> This change removes the workaround for the Buzz discovery document bug.
> Is that actually fixed?
>
> http://codereview.appspot.com/4515144/
>



-- 
Joe Gregorio        http://bitworking.org

Expand All Messages | Collapse All Messages