Issue 4515141: Show fatbits mode in openGL.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4515141: Show fatbits mode in openGL. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 6 months ago by Scroggo

Modified:
13 years, 6 months ago

Reviewers:
reed1

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Patch Set 1 #

Total comments: 2

Created: 13 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -2 lines)			Patch
	M	samplecode/SampleApp.cpp	View		4 chunks	+11 lines, -2 lines	2 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

reed1

http://codereview.appspot.com/4515141/diff/1/samplecode/SampleApp.cpp File samplecode/SampleApp.cpp (right): http://codereview.appspot.com/4515141/diff/1/samplecode/SampleApp.cpp#newcode708 samplecode/SampleApp.cpp:708: bitmap.unlockPixels(); Is this really needed? I thought the bitmaps ...

13 years, 6 months ago (2011-05-31 13:12:44 UTC) #2

Scroggo

13 years, 6 months ago (2011-05-31 17:04:40 UTC) #3

http://codereview.appspot.com/4515141/diff/1/samplecode/SampleApp.cpp
File samplecode/SampleApp.cpp (right):

http://codereview.appspot.com/4515141/diff/1/samplecode/SampleApp.cpp#newcode708
samplecode/SampleApp.cpp:708: bitmap.unlockPixels();
On 2011/05/31 13:12:44, reed1 wrote:
> Is this really needed? I thought the bitmaps destructor would take care of
this.
> If it is needed, perhaps we should use SkAutoLockPixels instead, up on line
637

You are correct: the destructor will call freePixels, which will call
unlockPixels, if necessary.  I'll remove it.

Expand All Messages | Collapse All Messages