Issue 4515134: [PDF] Rename ContentEntryAccessor to ScopedContentEntry.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4515134: [PDF] Rename ContentEntryAccessor to ScopedContentEntry. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 6 months ago by Steve VanDeBogart

Modified:
13 years, 6 months ago

Reviewers:
Chris Guillory

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

Description

[PDF] Rename ContentEntryAccessor to ScopedContentEntry. Committed: http://code.google.com/p/skia/source/detail?r=1416

Patch Set 2 : Address comments #

Created: 13 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -24 lines)			Patch
	M	include/pdf/SkPDFDevice.h	View	1	3 chunks	+2 lines, -3 lines	0 comments	Download
	M	src/pdf/SkPDFDevice.cpp	View		11 chunks	+21 lines, -21 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Chris Guillory

LGTM http://codereview.appspot.com/4515134/diff/1/include/pdf/SkPDFDevice.h File include/pdf/SkPDFDevice.h (right): http://codereview.appspot.com/4515134/diff/1/include/pdf/SkPDFDevice.h#newcode39 include/pdf/SkPDFDevice.h:39: class ContentEntryAccessor; Looks like we never needed this ...

13 years, 6 months ago (2011-05-24 22:06:34 UTC) #2

Steve VanDeBogart

13 years, 6 months ago (2011-05-24 23:12:22 UTC) #3

http://codereview.appspot.com/4515134/diff/1/include/pdf/SkPDFDevice.h
File include/pdf/SkPDFDevice.h (right):

http://codereview.appspot.com/4515134/diff/1/include/pdf/SkPDFDevice.h#newcode39
include/pdf/SkPDFDevice.h:39: class ContentEntryAccessor;
On 2011/05/24 22:06:34, Chris Guillory wrote:
> Looks like we never needed this line.

Done.

http://codereview.appspot.com/4515134/diff/1/include/pdf/SkPDFDevice.h#newcod...
include/pdf/SkPDFDevice.h:184: // the preferred method is to use the
ContentEntryAccessor helper class.
On 2011/05/24 22:06:34, Chris Guillory wrote:
> ContentEntryAccessor -> ScopedContentEntry

Done.

Expand All Messages | Collapse All Messages