Issue 4515074: [PDF] Fix windows SkFontHost::OpenStream for TTC fonts.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4515074: [PDF] Fix windows SkFontHost::OpenStream for TTC fonts. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 4 months ago by Steve VanDeBogart

Modified:
13 years, 4 months ago

Reviewers:
Chris Guillory, reed1

CC:
skia-review_googlegroups.com, arthurhsu

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

Description

[PDF] Fix windows SkFontHost::OpenStream for TTC fonts. Committed: http://code.google.com/p/skia/source/detail?r=1319

Patch Set 2 : Address comments #

Total comments: 1

Created: 13 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -5 lines)			Patch
	M	src/ports/SkFontHost_win.cpp	View	1	2 chunks	+15 lines, -5 lines	1 comment	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

Steve VanDeBogart

Still waiting for the compile to finish, but I think this will work.

13 years, 4 months ago (2011-05-13 03:25:06 UTC) #1

Chris Guillory

LGTM. I can only offer nit. Also you mentioned getting rid of the continue. http://codereview.appspot.com/4515074/diff/1/src/ports/SkFontHost_win.cpp ...

13 years, 4 months ago (2011-05-13 03:34:28 UTC) #2

Steve VanDeBogart

http://codereview.appspot.com/4515074/diff/1/src/ports/SkFontHost_win.cpp File src/ports/SkFontHost_win.cpp (right): http://codereview.appspot.com/4515074/diff/1/src/ports/SkFontHost_win.cpp#newcode793 src/ports/SkFontHost_win.cpp:793: const DWORD kTTCTag = *(DWORD*) "ttcf"; On 2011/05/13 03:34:28, ...

13 years, 4 months ago (2011-05-13 03:41:06 UTC) #3

reed1

need to fix the cast of "ttcf" http://codereview.appspot.com/4515074/diff/3/src/ports/SkFontHost_win.cpp File src/ports/SkFontHost_win.cpp (left): http://codereview.appspot.com/4515074/diff/3/src/ports/SkFontHost_win.cpp#oldcode792 src/ports/SkFontHost_win.cpp:792: SkStream* SkFontHost::OpenStream(SkFontID ...

13 years, 4 months ago (2011-05-16 12:01:41 UTC) #4

Chris Guillory

13 years, 4 months ago (2011-05-16 18:47:13 UTC) #5

If we make changes let's also fix up the "maxp" tag in the same file.

Expand All Messages | Collapse All Messages