Issue 4515071: use SkPath for GrPath, removing GrPathIter entirely

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4515071: use SkPath for GrPath, removing GrPathIter entirely (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 7 months ago by reed1

Modified:
13 years, 3 months ago

Reviewers:
bsalomon

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Patch Set 1 #

Patch Set 2 : remove references to GrPathIter.h #

Total comments: 1

Patch Set 3 : rebase #

Patch Set 4 : add tesselatedpathrenderer #

Created: 13 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+212 lines, -860 lines)			Patch
M	Makefile	View	1 2 3	1 chunk	+1 line, -0 lines	0 comments	Download
M	gpu/include/GrClipIterator.h	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	gpu/include/GrContext.h	View	1 2	3 chunks	+4 lines, -15 lines	0 comments	Download
M	gpu/include/GrFontScaler.h	View	1 2	2 chunks	+2 lines, -2 lines	0 comments	Download
M	gpu/include/GrGpu.h	View	1 2	1 chunk	+1 line, -2 lines	0 comments	Download
M	gpu/include/GrPath.h	View	1 2	1 chunk	+3 lines, -84 lines	0 comments	Download
M	gpu/include/GrPathIter.h	View	1 2	1 chunk	+0 lines, -74 lines	0 comments	Download
M	gpu/include/GrPathRenderer.h	View	1 2	7 chunks	+11 lines, -12 lines	0 comments	Download
M	gpu/include/GrTesselatedPathRenderer.h	View	1 2 3	1 chunk	+5 lines, -5 lines	0 comments	Download
M	gpu/src/GrClip.cpp	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	gpu/src/GrContext.cpp	View	1 2	5 chunks	+5 lines, -17 lines	0 comments	Download
M	gpu/src/GrGpu.cpp	View	1 2	4 chunks	+8 lines, -11 lines	0 comments	Download
D	gpu/src/GrPath.cpp	View	1 2	1 chunk	+0 lines, -523 lines	0 comments	Download
M	gpu/src/GrPathRenderer.cpp	View	1 2	8 chunks	+16 lines, -15 lines	0 comments	Download
M	gpu/src/GrPathUtils.h	View	1 2	1 chunk	+2 lines, -3 lines	0 comments	Download
M	gpu/src/GrPathUtils.cpp	View	1 2	2 chunks	+4 lines, -6 lines	0 comments	Download
M	gpu/src/GrTesselatedPathRenderer.cpp	View	1 2 3	6 chunks	+10 lines, -12 lines	0 comments	Download
M	gpu/src/GrTextContext.cpp	View	1 2	1 chunk	+2 lines, -2 lines	0 comments	Download
M	gpu/src/gr_files.mk	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	gpu/src/gr_unittests.cpp	View	1 2	1 chunk	+120 lines, -1 line	0 comments	Download
M	include/gpu/SkGr.h	View	1 2	5 chunks	+4 lines, -29 lines	0 comments	Download
M	src/gpu/SkGpuDevice.cpp	View	1 2	1 chunk	+1 line, -2 lines	0 comments	Download
M	src/gpu/SkGr.cpp	View	1 2	1 chunk	+0 lines, -36 lines	0 comments	Download
M	src/gpu/SkGrFontScaler.cpp	View	1 2	1 chunk	+2 lines, -2 lines	0 comments	Download
M	xcode/gpu/gpu.xcodeproj/project.pbxproj	View	1 2 3	10 chunks	+8 lines, -4 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

bsalomon

We'll have to make the sk->gr path changes in GrTesselatedPathRenderer as well. I'm pretty sure ...

13 years, 7 months ago (2011-05-12 19:23:41 UTC) #2

LGTM

Expand All Messages | Collapse All Messages