Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(4247)

Issue 45070044: Gives empty heights and widths to stencil-less accidentals.

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 4 months ago by MikeSol
Modified:
10 years, 4 months ago
Reviewers:
dak
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Gives empty heights and widths to stencil-less accidentals. In order to not trigger accidental stencil printing before line breaking, accidentals have height and width functions that do not look up the stencil property but rather an internal representation of the stencil. This is fine save when the stencil is manually overridden. This patch aims to deal with common cases of #'() and ##f. A more general approach will be needed for more exotic overrides.

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -6 lines) Patch
M lily/accidental.cc View 2 chunks +18 lines, -6 lines 3 comments Download

Messages

Total messages: 1
dak
10 years, 4 months ago (2013-12-25 22:31:38 UTC) #1
https://codereview.appspot.com/45070044/diff/1/lily/accidental.cc
File lily/accidental.cc (right):

https://codereview.appspot.com/45070044/diff/1/lily/accidental.cc#newcode65
lily/accidental.cc:65: return sten_p != SCM_EOL && sten_p != SCM_BOOL_F
Please avoid adding more C++ value comparisons of SCM values than we have
already.  This should rather read
return !(scm_is_null (sten_p) || scm_is_false (sten_p))

https://codereview.appspot.com/45070044/diff/1/lily/accidental.cc#newcode77
lily/accidental.cc:77: return sten_p != SCM_EOL && sten_p != SCM_BOOL_F
Same here.

https://codereview.appspot.com/45070044/diff/1/lily/accidental.cc#newcode138
lily/accidental.cc:138: if (sten_p != SCM_EOL && sten_p != SCM_BOOL_F
Same here.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b