Kill ResponseError

[awiner, 2009-04-20 19:08:27]

This is what it looks like to kill off ResponseError, and just go with HTTP
error codes.  I've kept the JSON-RPC message code consistent, though that could
go too.

[Sachin Shenoy, 2009-04-21 12:47:08]

Looks good to me.

And thanks for fixing this.

http://codereview.appspot.com/45044/diff/1/13
File
java/common/src/main/java/org/apache/shindig/protocol/DataServiceServlet.java
(right):

http://codereview.appspot.com/45044/diff/1/13#newcode141
Line 141: if (responseItem.getErrorCode() < 400) {
Should we be more strict here >= 200 && < 300? The spec allows -ev values to be
used as error code.

http://codereview.appspot.com/45044/diff/1/21
File java/common/src/main/java/org/apache/shindig/protocol/JsonRpcServlet.java
(right):

http://codereview.appspot.com/45044/diff/1/21#newcode204
Line 204: if (responseItem.getErrorCode() >= 400) {
ditto.

http://codereview.appspot.com/45044/diff/1/21#newcode266
Line 266: sendError(response, new
ResponseItem(HttpServletResponse.SC_BAD_REQUEST,
As per the spec.
"-32700 (Parse error)
Invalid JSON. An error occurred on the server while parsing the JSON text."

Should we bother to send this error code where we are sure it is json parse
error?

[ianboston, 2009-04-21 17:21:15]

The import order doesnt look quite right on some of these classes, but it didnt
look right to start with ?

also,
I am slightly concerned about binding the SPI to javax.servlet. Just a gut
feeling that binding the protocol impl all the way down the stack means you cant
use another protocol... but thats probably just unfounded as this is all about
http.

http://codereview.appspot.com/45044/diff/1/22
File
java/gadgets/src/main/java/org/apache/shindig/gadgets/http/InvalidationHandler.java
(right):

http://codereview.appspot.com/45044/diff/1/22#newcode31
Line 31: import javax.servlet.http.HttpServletResponse;
I have the following import order, as configured some time last year when the
code style was agreed.
 
8=javax
7=java
6=org
5=org.apache.abdera
4=org.apache.shindig
3=net
2=junit
1=com
0=com.google


0 is the first


I dont think either before or after the patch is correct. (might be wrong about
that)