Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(63)

Issue 4474046: Fix Linux texture format in SampleApp (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 7 months ago by Stephen White
Modified:
13 years, 7 months ago
Reviewers:
bsalomon
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

SampleApp builds skia on Linux with BGRA pixel order, but Ganesh's SampleApp assumes GL_RGBA texture format on all platforms except Windows (where it uses GL_BGRA), so texture colours come out wrong. As a temporary fix, do on Linux what we do on Windows, and assume GL_BGRA. (This should be made more general later, and the assumption of matching formats between Skia and Ganesh removed.)

Patch Set 1 #

Patch Set 2 : Whoops; upload the correct patch this time #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
gpu/include/GrGLConfig.h View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4
Stephen White
13 years, 7 months ago (2011-05-04 19:57:59 UTC) #1
Stephen White
Whoops; upload the correct patch this time
13 years, 7 months ago (2011-05-04 19:58:59 UTC) #2
bsalomon
LGTM On 2011/05/04 19:58:59, Stephen White wrote: > Whoops; upload the correct patch this time
13 years, 7 months ago (2011-05-04 20:06:12 UTC) #3
Stephen White
13 years, 7 months ago (2011-05-04 20:13:12 UTC) #4
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b