Issue 4465053: Replace GrStringBuilder with SkString

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4465053: Replace GrStringBuilder with SkString (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 2 months ago by bsalomon

Modified:
13 years, 2 months ago

Reviewers:
reed1

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Created: 13 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+88 lines, -228 lines)			Patch
M	gpu/include/GrStringBuilder.h	View	1	1 chunk	+2 lines, -158 lines	0 comments	Download
M	gpu/src/GrGLEffect.h	View	1	1 chunk	+6 lines, -6 lines	0 comments	Download
M	gpu/src/GrGLProgram.cpp	View	1	20 chunks	+60 lines, -61 lines	0 comments	Download
M	gpu/src/gr_files.mk	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	gyp/skia.gyp	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	include/core/SkString.h	View	1	2 chunks	+5 lines, -0 lines	0 comments	Download
M	src/core/SkString.cpp	View	1	1 chunk	+9 lines, -0 lines	0 comments	Download
M	xcode/gpu/gpu.xcodeproj/project.pbxproj	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download

Total messages: 2

closed with r1266 (verbal LGTM from Mike)