Issue 4457042: Fixes issues 1639 and 1640.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4457042: Fixes issues 1639 and 1640. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 11 months ago by MikeSol

Modified:
12 years, 9 months ago

Reviewers:
mike, Keith, carl.d.sorensen, hanwenn

CC:
lilypond-devel_gnu.org

Visibility:
Public.

Description

Fixes issues 1639 and 1640. Consecutive glissandos are typeset, and line breaks can happen with killed glissandi.

Patch Set 1 #

Patch Set 2 : Adds a regtest for consecutive glissandi. #

Total comments: 1

Created: 12 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+72 lines, -24 lines)			Patch
A	input/regression/glissando-chord-linebreak.ly	View		1 chunk	+29 lines, -0 lines	0 comments	Download
A	input/regression/glissando-consecutive.ly	View	1	1 chunk	+13 lines, -0 lines	0 comments	Download
M	lily/glissando-engraver.cc	View		5 chunks	+30 lines, -24 lines	1 comment	Download

Messages

Total messages: 7

Expand All Messages | Collapse All Messages

mike_apollinemike.com

On Apr 30, 2011, at 3:45 PM, Carl.D.Sorensen@gmail.com wrote: > Regtest for 1640? > > ...

12 years, 11 months ago (2011-04-30 22:49:45 UTC) #4

mike_apollinemike.com

On Apr 30, 2011, at 3:49 PM, mike@apollinemike.com wrote: > On Apr 30, 2011, at ...

12 years, 11 months ago (2011-05-01 00:45:20 UTC) #5

Keith

On 2011/05/01 00:45:20, mike_apollinemike.com wrote: > > Pushed as 475a1f94b5733476d746d2c012809f3f2e6f0fcc. > Mike, that commit was ...

12 years, 11 months ago (2011-05-05 06:39:01 UTC) #6

hanwenn

12 years, 9 months ago (2011-07-01 15:48:35 UTC) #7

http://codereview.appspot.com/4457042/diff/4001/lily/glissando-engraver.cc
File lily/glissando-engraver.cc (right):

http://codereview.appspot.com/4457042/diff/4001/lily/glissando-engraver.cc#ne...
lily/glissando-engraver.cc:89: kill_me_.push_back (lines_[i]);
why  not do the suicide immediately?

Expand All Messages | Collapse All Messages