Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(675)

Issue 4454047: [PDF] Fix fallout from r1217. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 2 months ago by Steve VanDeBogart
Modified:
13 years, 2 months ago
Reviewers:
Chris Guillory, reed1
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlecode.com/svn/trunk
Visibility:
Public.

Description

[PDF] Fix fallout from r1217. The width and height we pass to SkDevice must be postive. Shader can no longer use negative coordinates (without transform). Shader unflip matrix should use same values as passed to SkPDFDevice (height). Most Shader dictionary entries should be scalars and not ints. Committed: http://code.google.com/p/skia/source/detail?r=1219

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -15 lines) Patch
M include/pdf/SkPDFDevice.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/pdf/SkPDFDevice.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/pdf/SkPDFShader.cpp View 7 chunks +17 lines, -14 lines 0 comments Download

Messages

Total messages: 3
Steve VanDeBogart
13 years, 2 months ago (2011-05-02 04:17:17 UTC) #1
Chris Guillory
LGTM
13 years, 2 months ago (2011-05-02 08:51:43 UTC) #2
reed1
13 years, 2 months ago (2011-05-02 11:55:44 UTC) #3
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b