Issue 4454: zlib and zipimport should use bytes not bytearray - issue3492

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4454: zlib and zipimport should use bytes not bytearray - issue3492

Can't Edit
Can't Publish+Mail
Start Review

Created:
16 years, 8 months ago by gregory.p.smith

Modified:
15 years, 9 months ago

Reviewers:
Benjamin, amaury, pitrou

Base URL:
http://svn.python.org/view/*checkout*/python/branches/py3k/

Visibility:
Public.

Description

see http://bugs.python.org/issue3492

Patch Set 1 #

Created: 16 years, 8 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Stats (+46 lines, -40 lines)			Patch
Lib/test/test_zlib.py	View	2 chunks	+8 lines, -2 lines	1 comment	Download
Modules/zipimport.c	View	7 chunks	+11 lines, -11 lines	0 comments	Download
Modules/zlibmodule.c	View	20 chunks	+27 lines, -27 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Benjamin

16 years, 8 months ago (2008-09-05 00:36:22 UTC) #2

Looks pretty good. Just one comment.

http://codereview.appspot.com/4454/diff/1/2
File Lib/test/test_zlib.py (right):

http://codereview.appspot.com/4454/diff/1/2#newcode157
Line 157: self.assertEqual(type(decombuf), bytes)
I think assert_(isinstance(decombuf, bytes)) should be used.

Expand All Messages | Collapse All Messages