Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(187)

Issue 4454: zlib and zipimport should use bytes not bytearray - issue3492

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years, 6 months ago by gregory.p.smith
Modified:
14 years, 7 months ago
Reviewers:
Benjamin, amaury, pitrou
Base URL:
http://svn.python.org/view/*checkout*/python/branches/py3k/
Visibility:
Public.

Description

see http://bugs.python.org/issue3492

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -40 lines) Patch
Lib/test/test_zlib.py View 2 chunks +8 lines, -2 lines 1 comment Download
Modules/zipimport.c View 7 chunks +11 lines, -11 lines 0 comments Download
Modules/zlibmodule.c View 20 chunks +27 lines, -27 lines 0 comments Download

Messages

Total messages: 2
gregory.p.smith
15 years, 6 months ago (2008-09-05 00:07:03 UTC) #1
Benjamin
15 years, 6 months ago (2008-09-05 00:36:22 UTC) #2
Looks pretty good. Just one comment.

http://codereview.appspot.com/4454/diff/1/2
File Lib/test/test_zlib.py (right):

http://codereview.appspot.com/4454/diff/1/2#newcode157
Line 157: self.assertEqual(type(decombuf), bytes)
I think assert_(isinstance(decombuf, bytes)) should be used.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b