Issue 4453051: Move attrib-list handling into Display

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4453051: Move attrib-list handling into Display (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 4 months ago by John Bauman

Modified:
14 years, 4 months ago

Reviewers:
dgkoch

CC:
angleproject-review_googlegroups.com

Base URL:
https://angleproject.googlecode.com/svn/trunk

Visibility:
Public.

Description

Move attrib-list handling into Display Move the handling of attrib-lists in eglCreatePbufferSurface and eglCreateWindowList into methods in Display, so we can keep libEGL.cpp as a thin layer. BUG= TEST= Committed: http://code.google.com/p/angleproject/source/detail?r=628

Patch Set 1 #

Created: 14 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+133 lines, -145 lines)			Patch
M	src/libEGL/Display.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/libEGL/Display.cpp	View	2 chunks	+129 lines, -4 lines	0 comments	Download
M	src/libEGL/libEGL.cpp	View	3 chunks	+2 lines, -139 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

dgkoch

14 years, 4 months ago (2011-04-29 04:48:45 UTC) #2

LGTM.  (although be careful with potential merge issues w/ one of Al's patches)

Expand All Messages | Collapse All Messages