Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(406)

Issue 4452052: Give a fix-it for improperly nested namespaces (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 8 months ago by rtrieu
Modified:
13 years, 7 months ago
Reviewers:
chandlerc
Base URL:
http://llvm.org/svn/llvm-project/cfe/trunk/
Visibility:
Public.

Description

Committed at revision 132138.

Patch Set 1 #

Patch Set 2 : Move both fixits to error message. #

Patch Set 3 : Change the recovery parsing to not alter the token stream. #

Patch Set 4 : Fix a caret on an error message. #

Patch Set 5 : Add spaces between suggested closing brackets and only pass inline to inner most namespace. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+118 lines, -7 lines) Patch
M include/clang/Basic/DiagnosticParseKinds.td View 1 1 chunk +2 lines, -0 lines 0 comments Download
M include/clang/Parse/Parser.h View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
M lib/Parse/ParseDeclCXX.cpp View 1 2 3 4 4 chunks +86 lines, -7 lines 0 comments Download
A test/Parser/nested-namespaces-recovery.cpp View 1 2 1 chunk +24 lines, -0 lines 0 comments Download

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b