Update prediction to 1.2, automate the generation of common samples.

[ade, 2011-04-28 17:33:31]

http://codereview.appspot.com/4449062/diff/6001/samples/src/prediction.py
File samples/src/prediction.py (right):

http://codereview.appspot.com/4449062/diff/6001/samples/src/prediction.py#new...
samples/src/prediction.py:18: while 1:
Use while True instead

http://codereview.appspot.com/4449062/diff/6001/samples/src/template.tmpl
File samples/src/template.tmpl (right):

http://codereview.appspot.com/4449062/diff/6001/samples/src/template.tmpl#new...
samples/src/template.tmpl:87: if credentials is None or credentials.invalid ==
True:
Use:
if credentials is None or credentials.invalid:

I'm assuming that credentials.invalid can only ever have the values True or
False and it will never be None

http://codereview.appspot.com/4449062/diff/6001/samples/src/urlshortener.py
File samples/src/urlshortener.py (right):

http://codereview.appspot.com/4449062/diff/6001/samples/src/urlshortener.py#n...
samples/src/urlshortener.py:13: shortUrl = resp['id']
Please rename to short_url. This means that line 16 will say: shortUrl=short_url
and hopefully will make it clear that the camel-case argument names are imposed
by the API

http://codereview.appspot.com/4449062/diff/6001/samples/urlshortener/urlshort...
File samples/urlshortener/urlshortener.py (right):

http://codereview.appspot.com/4449062/diff/6001/samples/urlshortener/urlshort...
samples/urlshortener/urlshortener.py:56: # The client_id client_secret are
copied from the Identity tab on
I've just realised that the API Console no longer has an Identity tab so all
code samples that mention it are now incorrect. I now tell developers to go to
the Console and say they're building an Installed Application.

[jcgregorio_google, 2011-04-29 13:38:35]

http://codereview.appspot.com/4449062/diff/6001/samples/src/prediction.py
File samples/src/prediction.py (right):

http://codereview.appspot.com/4449062/diff/6001/samples/src/prediction.py#new...
samples/src/prediction.py:18: while 1:
On 2011/04/28 17:33:31, ade wrote:
> Use while True instead

Done.

http://codereview.appspot.com/4449062/diff/6001/samples/src/template.tmpl
File samples/src/template.tmpl (right):

http://codereview.appspot.com/4449062/diff/6001/samples/src/template.tmpl#new...
samples/src/template.tmpl:87: if credentials is None or credentials.invalid ==
True:
On 2011/04/28 17:33:31, ade wrote:
> Use:
> if credentials is None or credentials.invalid:
> 
> I'm assuming that credentials.invalid can only ever have the values True or
> False and it will never be None

Done.

http://codereview.appspot.com/4449062/diff/6001/samples/src/urlshortener.py
File samples/src/urlshortener.py (right):

http://codereview.appspot.com/4449062/diff/6001/samples/src/urlshortener.py#n...
samples/src/urlshortener.py:13: shortUrl = resp['id']
On 2011/04/28 17:33:31, ade wrote:
> Please rename to short_url. This means that line 16 will say:
shortUrl=short_url
> and hopefully will make it clear that the camel-case argument names are
imposed
> by the API

Done.

http://codereview.appspot.com/4449062/diff/6001/samples/urlshortener/urlshort...
File samples/urlshortener/urlshortener.py (right):

http://codereview.appspot.com/4449062/diff/6001/samples/urlshortener/urlshort...
samples/urlshortener/urlshortener.py:56: # The client_id client_secret are
copied from the Identity tab on
On 2011/04/28 17:33:31, ade wrote:
> I've just realised that the API Console no longer has an Identity tab so all
> code samples that mention it are now incorrect. I now tell developers to go to
> the Console and say they're building an Installed Application.

Done.

[ade, 2011-05-02 21:25:42]

LGTM