Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(775)

Issue 4447056: Fix engine exits with g_object_new when restart the engine. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 10 months ago by Daiki Ueno
Modified:
14 years, 10 months ago
Reviewers:
shawn.p.huang, Peng
CC:
fujiwara
Base URL:
git@github.com:ibus/ibus-m17n.git@master
Visibility:
Public.

Description

Fix engine exits with g_object_new when restart the engine. ibus <= 1.3 explicitly destroys engine when unset. Which may result in unloading the m17n type module and crash on restart. This patch prevents the type module from being unloaded. BUG=https://bugzilla.redhat.com/show_bug.cgi?id=696476#c9 TEST=manual Patch from Takao Fujiwara <takao.fujiwara1@gmail.com>

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M src/engine.c View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 4
Daiki Ueno
14 years, 10 months ago (2011-04-20 07:20:59 UTC) #1
Peng
On 2011/04/20 07:20:59, Daiki Ueno wrote: Could you explain why we need GTypeModule? Could we ...
14 years, 10 months ago (2011-04-20 16:05:40 UTC) #2
Daiki Ueno
On 2011/04/20 16:05:40, Peng wrote: > Could you explain why we need GTypeModule? Could we ...
14 years, 10 months ago (2011-04-21 00:57:11 UTC) #3
Daiki Ueno
14 years, 10 months ago (2011-04-27 01:56:00 UTC) #4
Closing this as a new patch is posted at http://codereview.appspot.com/4431056/.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b