Issue 4446051: Use g_initable_new to create BusFactoryProxy.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4446051: Use g_initable_new to create BusFactoryProxy. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years ago by Peng

Modified:
13 years ago

Reviewers:
Yusuke Sato

CC:
satorux

Base URL:
git@github.com:ibus/ibus.git@master

Visibility:
Public.

Description

Use g_initable_new to create BusFactoryProxy. BUG=none TEST=Linux desktop

Patch Set 3 : Update #

Created: 13 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -10 lines)			Patch
	M	bus/factoryproxy.c	View	1	2 chunks	+15 lines, -10 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Yusuke Sato

LGTM with one nit below: http://codereview.appspot.com/4446051/diff/1/bus/factoryproxy.c File bus/factoryproxy.c (right): http://codereview.appspot.com/4446051/diff/1/bus/factoryproxy.c#newcode66 bus/factoryproxy.c:66: factory = (BusFactoryProxy *) ...

13 years ago (2011-04-18 14:51:29 UTC) #2

Peng

http://codereview.appspot.com/4446051/diff/1/bus/factoryproxy.c File bus/factoryproxy.c (right): http://codereview.appspot.com/4446051/diff/1/bus/factoryproxy.c#newcode66 bus/factoryproxy.c:66: factory = (BusFactoryProxy *) g_initable_new ( On 2011/04/18 14:51:29, ...

13 years ago (2011-04-18 15:17:50 UTC) #3

Yusuke Sato

13 years ago (2011-04-18 15:20:03 UTC) #4

http://codereview.appspot.com/4446051/diff/1/bus/factoryproxy.c
File bus/factoryproxy.c (right):

http://codereview.appspot.com/4446051/diff/1/bus/factoryproxy.c#newcode66
bus/factoryproxy.c:66: factory = (BusFactoryProxy *) g_initable_new (
Thanks for the explanation. Could you copy&paste your comment to the code?

On 2011/04/18 15:17:50, Peng wrote:
> On 2011/04/18 14:51:29, Yusuke Sato wrote:
> > I'd like to know when factory can be NULL. Can you add some comments?
> 
> It is unlikely. But in some case, the connection could be closed during
creating
> the proxy object. And then g_initable_new will return NULL.
> 
> https://github.com/ibus/ibus/blob/master/src/ibusproxy.c#L162

Expand All Messages | Collapse All Messages