Issue 4445075: Super-Sample improvements

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4445075: Super-Sample improvements (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 6 months ago by bsalomon

Modified:
14 years, 5 months ago

Reviewers:
reed1

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Patch Set 2 : remove debugging code #

Patch Set 4 : verify that only the texcache size has been changed since last upload #

Created: 14 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+383 lines, -199 lines)			Patch
M	gpu/include/GrContext.h	View		2 chunks	+10 lines, -7 lines	0 comments	Download
M	gpu/include/GrContext_impl.h	View		3 chunks	+22 lines, -52 lines	0 comments	Download
M	gpu/include/GrDrawTarget.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	gpu/include/GrGpu.h	View		2 chunks	+6 lines, -0 lines	0 comments	Download
M	gpu/include/GrPathRenderer.h	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	gpu/include/GrRect.h	View	1	4 chunks	+59 lines, -1 line	0 comments	Download
M	gpu/include/GrTexture.h	View	1	3 chunks	+20 lines, -9 lines	0 comments	Download
M	gpu/src/GrContext.cpp	View	1 2 3	9 chunks	+189 lines, -104 lines	0 comments	Download
M	gpu/src/GrGLTexture.cpp	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	gpu/src/GrGpuGL.h	View	1	1 chunk	+3 lines, -1 line	0 comments	Download
M	gpu/src/GrGpuGL.cpp	View	1 2	11 chunks	+34 lines, -18 lines	0 comments	Download
M	gpu/src/GrTexture.cpp	View	1	1 chunk	+22 lines, -0 lines	0 comments	Download
M	samplecode/SampleTypeface.cpp	View	1 2 3	1 chunk	+1 line, -0 lines	0 comments	Download
M	samplecode/SampleVertices.cpp	View		1 chunk	+13 lines, -4 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

bsalomon

Adds 4x4, fixup when to not apply this technique, add option for MSAA when available.

14 years, 6 months ago (2011-04-29 19:15:55 UTC) #1

reed1

http://codereview.appspot.com/4445075/diff/3002/gpu/src/GrContext.cpp File gpu/src/GrContext.cpp (right): http://codereview.appspot.com/4445075/diff/3002/gpu/src/GrContext.cpp#newcode36 gpu/src/GrContext.cpp:36: static const size_t MAX_TEXTURE_CACHE_BYTES = 1000 * 1024 * ...

14 years, 6 months ago (2011-05-02 11:50:31 UTC) #2

bsalomon

14 years, 6 months ago (2011-05-02 12:35:50 UTC) #3

On Mon, May 2, 2011 at 7:50 AM, <reed@google.com> wrote:

>
>
>
http://codereview.appspot.com/4445075/diff/3002/gpu/src/GrContext.cpp#newcode36
> gpu/src/GrContext.cpp:36: static const size_t MAX_TEXTURE_CACHE_BYTES =
> 1000 * 1024 * 1024;
> 1 Gig may be too large of a cache to check in
>
> Definitely. I forgot to revert that part of the change.


>
> http://codereview.appspot.com/4445075/
>

Expand All Messages | Collapse All Messages