Keyboard Shortcuts
File
u
:
up to issue
m
:
publish + mail comments
M
:
edit review message
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
<Enter>
:
respond to / edit current comment
d
:
mark current comment as done
Issue
u
:
up to list of issues
m
:
publish + mail comments
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
#
:
close issue
Comment/message editing
<Ctrl>
+
s
or
<Ctrl>
+
Enter
:
save comment
<Esc>
:
cancel edit
Rietveld
Code Review Tool
Help
|
Bug tracker
|
Discussion group
|
Source code
|
Sign in
(461)
Issues
Repositories
Search
Open Issues
|
Closed Issues
|
All Issues
|
Sign in
with your
Google Account
to create issues and add comments
Issue
4442093
: Add clearRect to GrDrawTarget to clear a rectangle (Closed)
Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 8 months ago by
bsalomon
Modified:
13 years, 8 months ago
Reviewers:
reed1
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.
Patch Set 1
#
Patch Set 2 : misc
#
Patch Set 3 : merge clearRect with clear
#
Created:
13 years, 8 months ago
Download
[raw]
[tar.bz2]
Unified diffs
Side-by-side diffs
Delta from patch set
Stats
(
+63 lines, -33 lines
)
Patch
M
include/GrContext.h
View
1
2
1 chunk
+4 lines, -2 lines
0 comments
Download
M
include/GrDrawTarget.h
View
1
2
1 chunk
+4 lines, -3 lines
0 comments
Download
M
include/GrGpu.h
View
1
2
2 chunks
+4 lines, -3 lines
0 comments
Download
M
include/GrInOrderDrawBuffer.h
View
1
2
2 chunks
+2 lines, -1 line
0 comments
Download
M
include/GrRect.h
View
1
1 chunk
+5 lines, -2 lines
0 comments
Download
M
src/GrContext.cpp
View
1
2
2 chunks
+3 lines, -5 lines
0 comments
Download
M
src/GrGpu.cpp
View
1
2
1 chunk
+2 lines, -2 lines
0 comments
Download
M
src/GrGpuGL.h
View
1
3 chunks
+4 lines, -2 lines
0 comments
Download
M
src/GrGpuGL.cpp
View
1
2
1 chunk
+15 lines, -5 lines
0 comments
Download
M
src/GrInOrderDrawBuffer.cpp
View
1
2
4 chunks
+20 lines, -8 lines
0 comments
Download
Messages
Total messages: 4
Expand All Messages
|
Collapse All Messages
bsalomon
13 years, 8 months ago (2011-04-27 18:50:23 UTC)
#1
Sign in
to reply to this message.
bsalomon
now with unified clear and clearRect
13 years, 8 months ago (2011-04-27 19:26:38 UTC)
#2
now with unified clear and clearRect
Sign in
to reply to this message.
bsalomon
Got a verbal LGTM, closing with r1203.
13 years, 8 months ago (2011-04-27 19:56:17 UTC)
#3
Got a verbal LGTM, closing with r1203.
Sign in
to reply to this message.
reed1
LGTM
13 years, 8 months ago (2011-04-27 20:56:58 UTC)
#4
LGTM
Sign in
to reply to this message.
Expand All Messages
|
Collapse All Messages
Issue 4442093: Add clearRect to GrDrawTarget to clear a rectangle (Closed)
Created 13 years, 8 months ago by bsalomon
Modified 13 years, 8 months ago
Reviewers: reed1
Base URL: http://skia.googlecode.com/svn/trunk/
Comments: 0
Recent Issues
|
This issue
This is Rietveld
f62528b