Issue 44420043: Doc: NR improve example of \accepts (Closed)
|
Created:
10 years, 4 months ago by pkx166h Modified:
10 years, 3 months ago CC:
lilypond-devel_gnu.org Visibility:
Public. |
DescriptionDoc: NR improve example of \accepts
Issue 3641
Improve example given in NR 5.1.7
Patch Set 1 #
Total comments: 2
Patch Set 2 : Keith's additions. #
Total comments: 5
Patch Set 3 : Trevor's suggestions with a modified first example #Patch Set 4 : TexInfo Corrections #MessagesTotal messages: 10
You want to change the text as well as the example. Giving four staves lets a user see more clearly what happens if he removes \accepts. https://codereview.appspot.com/44420043/diff/1/Documentation/notation/changin... File Documentation/notation/changing-defaults.itely (right): https://codereview.appspot.com/44420043/diff/1/Documentation/notation/changin... Documentation/notation/changing-defaults.itely:1347: from the list. For example, it would not normally be desirable for For example, a square-braced staff group is not usually found within a curved-braced staff with connecting staff bars, and a @code{GrandStaff} does not accept a @code{StaffGroup} inside it by default. If this were required it can be done: \new GrandStaff \with {\accepts StaffGroup } << \new Staff { c''1 } \new StaffGroup << \new Staff { g'1 } \new Staff { e'1 } >> \new Staff {c'1 } >>
Sign in to reply to this message.
Keith's additions. Thank you. https://codereview.appspot.com/44420043/diff/1/Documentation/notation/changin... File Documentation/notation/changing-defaults.itely (right): https://codereview.appspot.com/44420043/diff/1/Documentation/notation/changin... Documentation/notation/changing-defaults.itely:1347: from the list. For example, it would not normally be desirable for On 2013/12/21 04:50:56, Keith wrote: > For example, a square-braced staff group is not usually found within a > curved-braced staff with connecting staff bars, and a @code{GrandStaff} does not > accept a @code{StaffGroup} inside it by default. If this were required it can > be done: > > \new GrandStaff \with {\accepts StaffGroup } << > \new Staff { c''1 } > \new StaffGroup << > \new Staff { g'1 } > \new Staff { e'1 } >> > \new Staff {c'1 } >> > Thank you. Done.
Sign in to reply to this message.
Keith's additions.
Sign in to reply to this message.
Needs a few more changes ... https://codereview.appspot.com/44420043/diff/20001/Documentation/notation/cha... File Documentation/notation/changing-defaults.itely (right): https://codereview.appspot.com/44420043/diff/20001/Documentation/notation/cha... Documentation/notation/changing-defaults.itely:1356: \chords { d1:m7 b1:min7.5- } The idea of this snippet was to show what happened before using \accepts. So this one needs changing to correspond with the one below. Maybe the wording could be changed to make this clearer, or comments could be added to the code. https://codereview.appspot.com/44420043/diff/20001/Documentation/notation/cha... Documentation/notation/changing-defaults.itely:1373: \accepts "ChordNames" In the changed example we don't need anything about ChordNames
Sign in to reply to this message.
Trevor's suggestions with a modified first example
Sign in to reply to this message.
Thanks Trevor. Could someone come up with a good example for \denies? I think this written example is that obvious and it would be nice to use a similar example as above but \denies something in a GrandStaff context - just to compare and contrast more obviously. https://codereview.appspot.com/44420043/diff/20001/Documentation/notation/cha... File Documentation/notation/changing-defaults.itely (right): https://codereview.appspot.com/44420043/diff/20001/Documentation/notation/cha... Documentation/notation/changing-defaults.itely:1356: \chords { d1:m7 b1:min7.5- } On 2013/12/25 09:05:15, Trevor Daniels wrote: > The idea of this snippet was to show what > happened before using \accepts. So this one > needs changing to correspond with the one > below. Maybe the wording could be changed > to make this clearer, or comments could be > added to the code. Done. https://codereview.appspot.com/44420043/diff/20001/Documentation/notation/cha... Documentation/notation/changing-defaults.itely:1373: \accepts "ChordNames" On 2013/12/25 09:05:15, Trevor Daniels wrote: > In the changed example we don't need anything > about ChordNames Done. https://codereview.appspot.com/44420043/diff/20001/Documentation/notation/cha... Documentation/notation/changing-defaults.itely:1387: context in the @qq{accepts} list. Could someone come up with a good example for \denies? I think this written example is that obvious and it would be nice to use a similar example as above but \denies something in a GrandStaff context - just to compare and contrast more obviously.
Sign in to reply to this message.
On 2013/12/26 18:54:07, J_lowe wrote: > Could someone come up with a good example for \denies? I don't think there is one. We can always leave a context out of the enclosing context that would 'deny' it. The meaning of \denies is clear enough from the context with the dictionary definition of the English word 'denies', so the text alone lets people know that it exists. Some predefined contexts like TabStaff use \denies, when they copy another context using \alias and then adjust that copy, but that use is already described well enough in section 5.1.6.
Sign in to reply to this message.
TexInfo Corrections
Sign in to reply to this message.
On 2013/12/26 19:31:35, Keith wrote: > On 2013/12/26 18:54:07, J_lowe wrote: > > > Could someone come up with a good example for \denies? > > I don't think there is one. We can always leave a context out of the enclosing > context that would 'deny' it. The meaning of \denies is clear enough from the > context with the dictionary definition of the English word 'denies', so the text > alone lets people know that it exists. It's conceivable to use \addlyrics but let \denies push either the reference context or the lyrics context out of the current Staff/StaffGroup. Saves one \lyricsto, but is likely a rather obscure trick without really convincing necessity.
Sign in to reply to this message.
author James Lowe <pkx166h@gmail.com> Fri, 20 Dec 2013 00:03:22 +0000 (00:03 +0000) committer James Lowe <pkx166h@gmail.com> Sat, 4 Jan 2014 12:23:06 +0000 (12:23 +0000) commit f083dbe9c8743e3a1fc4ce1aea085b114e263d6d
Sign in to reply to this message.
|
