Issue 4441067: Update GR_API to support non-Windows DLLs.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 8 months ago by evan

Modified:
13 years, 8 months ago

Reviewers:
bsalomon

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Update GR_API to support non-Windows DLLs. Export the symbols following the pattern we use elsewhere.

Created: 13 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -4 lines)			Patch
	M	gpu/include/GrConfig.h	View		1 chunk	+8 lines, -4 lines	0 comments	Download

Total messages: 5

bsalomon

LGTM. Does SK_API also need to be updated? On 2011/04/25 23:35:24, evan wrote:

13 years, 8 months ago (2011-04-26 12:12:27 UTC) #2

bsalomon

On Tue, Apr 26, 2011 at 8:12 AM, <bsalomon@google.com> wrote: > LGTM. Does SK_API also ...

13 years, 8 months ago (2011-04-26 12:15:56 UTC) #3

evan

On 2011/04/26 12:15:56, bsalomon wrote: > On Tue, Apr 26, 2011 at 8:12 AM, <mailto:bsalomon@google.com> ...

13 years, 8 months ago (2011-04-26 16:42:10 UTC) #4

bsalomon

13 years, 8 months ago (2011-04-26 17:59:48 UTC) #5

> 
> I don't have commit access; can you land this for me?

Done with r1189.