Extend GM to test SkPicture and serialization - Patch Set 2

* add tests of playback and serialization to gm
* pull 90 lines of code out of main() and into a bunch of little functions to make reuse in the new test cases easier
* replace tabs with spaces to fit coding standards

[reed1, 2011-04-25 14:19:17]

good start.

Some general style comments (sometime you did these correctly, sometimes not). I
recognize the existing code was probably bad or inconsistent in these.

braces:

void function(...) {

if (condition) {   // always, even for 1-liners

indent: always 4

argument passing:

const arguments (in general) are const& if required, and const* if optional
(though we don't always follow this).

variable arguments are always * (so the caller can tell that we're (logically)
passing by value).

http://codereview.appspot.com/4440063/diff/1/gm/gmmain.cpp
File gm/gmmain.cpp (right):

http://codereview.appspot.com/4440063/diff/1/gm/gmmain.cpp#newcode334
gm/gmmain.cpp:334: int streamSize = storage.getOffset();
Might try SkAutoMalloc (or the S (stack allocated) variants) for this temp
storage.

SkAutoMalloc storage(streamSize);
void* dst = storage.get();

Then no need to explicitly free it at the end. You can just have

return new SkPicture(&pictReadback);

http://codereview.appspot.com/4440063/diff/1/gm/gmmain.cpp#newcode374
gm/gmmain.cpp:374: SkPicture* pict = generate_new_picture(gm);
Might replace the trailing pict->unref() with this helper right after the
generate_ call.

SkAutoUnref aur(pict);

[reed1, 2011-04-25 15:21:17]

LGTM (with tiny style edits)

On a future CL, we might add/upgrade the -help to declare what the options are.

http://codereview.appspot.com/4440063/diff/4001/gm/gmmain.cpp
File gm/gmmain.cpp (right):

http://codereview.appspot.com/4440063/diff/4001/gm/gmmain.cpp#newcode191
gm/gmmain.cpp:191: {
move brace to after bitmap)

http://codereview.appspot.com/4440063/diff/4001/gm/gmmain.cpp#newcode200
gm/gmmain.cpp:200: {
ditto

[reed1, 2011-04-25 15:42:48]

LGTM

[TomH, 2011-04-25 15:51:35]

Committed as revision 1171.