Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(718)

Issue 4440060: Fix SEGV in im-ibus.so on Chromium OS (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 11 months ago by Yusuke Sato
Modified:
12 years, 11 months ago
Reviewers:
shawn.p.huang, Peng Huang, Daiki Ueno
Base URL:
git@github.com:ibus/ibus.git@master
Visibility:
Public.

Description

Fix SEGV in im-ibus.so on Chromium OS

Patch Set 1 #

Total comments: 2

Patch Set 2 : review fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M client/gtk2/ibusimcontext.c View 1 2 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 3
Yusuke Sato
It seems that the latest ibus does not work fine on Chromium OS. Here is ...
12 years, 11 months ago (2011-04-22 10:00:38 UTC) #1
Peng
LGTM http://codereview.appspot.com/4440060/diff/1/client/gtk2/ibusimcontext.c File client/gtk2/ibusimcontext.c (right): http://codereview.appspot.com/4440060/diff/1/client/gtk2/ibusimcontext.c#newcode371 client/gtk2/ibusimcontext.c:371: _request_surrounding_text (ibusimcontext, FALSE); It is better to move ...
12 years, 11 months ago (2011-04-22 11:13:00 UTC) #2
Yusuke Sato
12 years, 11 months ago (2011-04-22 11:16:52 UTC) #3
submitting

http://codereview.appspot.com/4440060/diff/1/client/gtk2/ibusimcontext.c
File client/gtk2/ibusimcontext.c (right):

http://codereview.appspot.com/4440060/diff/1/client/gtk2/ibusimcontext.c#newc...
client/gtk2/ibusimcontext.c:371: _request_surrounding_text (ibusimcontext,
FALSE);
On 2011/04/22 11:13:01, Peng wrote:
> It is better to move this line into an if (ibusimcontext != NULL) block

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b