Issue 4440060: Fix SEGV in im-ibus.so on Chromium OS

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4440060: Fix SEGV in im-ibus.so on Chromium OS (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 7 months ago by Yusuke Sato

Modified:
13 years, 7 months ago

Reviewers:
shawn.p.huang, Peng Huang, Daiki Ueno

Base URL:
git@github.com:ibus/ibus.git@master

Visibility:
Public.

Patch Set 2 : review fix #

Created: 13 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -3 lines)			Patch
	M	client/gtk2/ibusimcontext.c	View	1	2 chunks	+2 lines, -3 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Yusuke Sato

It seems that the latest ibus does not work fine on Chromium OS. Here is ...

13 years, 7 months ago (2011-04-22 10:00:38 UTC) #1

Peng

LGTM http://codereview.appspot.com/4440060/diff/1/client/gtk2/ibusimcontext.c File client/gtk2/ibusimcontext.c (right): http://codereview.appspot.com/4440060/diff/1/client/gtk2/ibusimcontext.c#newcode371 client/gtk2/ibusimcontext.c:371: _request_surrounding_text (ibusimcontext, FALSE); It is better to move ...

13 years, 7 months ago (2011-04-22 11:13:00 UTC) #2

Yusuke Sato

13 years, 7 months ago (2011-04-22 11:16:52 UTC) #3

submitting

http://codereview.appspot.com/4440060/diff/1/client/gtk2/ibusimcontext.c
File client/gtk2/ibusimcontext.c (right):

http://codereview.appspot.com/4440060/diff/1/client/gtk2/ibusimcontext.c#newc...
client/gtk2/ibusimcontext.c:371: _request_surrounding_text (ibusimcontext,
FALSE);
On 2011/04/22 11:13:01, Peng wrote:
> It is better to move this line into an if (ibusimcontext != NULL) block

Done.

Expand All Messages | Collapse All Messages