Fix the zombie process of ibus-gconf when ibus-daemon restarts.

Fix the zombie process of ibus-gconf when ibus-daemon restarts.

- Fix the typo in bus_dbus_impl_destroy() (dbusimpl.c)
- Modify bus_server_run() and _ibus_exit() (ibusimpl.c, server.c)
  bus_ibus_impl_destroy() needs to be called so that waitpid()
  prevents processes from becoming zombie.
- Change the declaration of bus_server_quit(). (server.h)

BUG=redhat#697471
TEST=Linux desktop

[fujiwara, 2011-04-22 04:19:26]

Originally I just added bus_ibus_impl_destroy() in _ibus_exit() so that
waitpid() is called.
But talking off line, it's suggested to move the codes in _ibus_exit() into
bus_server_run().
I revised the patch to fix zombie processes.

There is still another issue.
When ibus-daemon restarts, the following warning is printed from gtk client:
(gnome-terminal:22037): IBUS-WARNING **: _connection_closed_cb: Underlying
GIOStream returned 0 bytes on an async read

The warning is set by gdbus:
#0  set_closed_unlocked () from /usr/lib64/libgio-2.0.so
#1  on_worker_closed () from /usr/lib64/libgio-2.0.so
#2  g_dbus_worker_emit_disconnected ()
    from /usr/lib64/libgio-2.0.so
#3  _g_dbus_worker_do_read_cb ()
    from /usr/lib64/libgio-2.0.so
#4  g_simple_async_result_complete ()
    from /usr/lib64/libgio-2.0.so
#5  _g_socket_read_with_control_messages_ready ()
    from /usr/lib64/libgio-2.0.so
#6  socket_source_dispatch ()
    from /usr/lib64/libgio-2.0.so
#7  g_main_dispatch (context=0x7fa59c009440)
    from /usr/lib64/libglib-2.0.so

#3  0x00007fa5a873b8cd in _g_dbus_worker_do_read_cb (input_stream=
693       /* TODO: hmm, hmm... */
694       if (bytes_read == 0)
695         {
696           g_set_error (&error,
697                        G_IO_ERROR,
698                        G_IO_ERROR_FAILED,
699                        "Underlying GIOStream returned 0 bytes on an async
read");
700           _g_dbus_worker_emit_disconnected (worker, TRUE, error);
701           g_error_free (error);
702           goto out;
703         }

I tried to add g_dbus_connection_flush_sync() in bus_ibus_impl_destroy() but it
could not be resolved.
If ibus-daemon closes the dbus connection, it seems gtk client still connects it
and gets the 0 byte.

I'm thinking add a new dbus method to remove the callback method
_connection_closed_cb() in gtk client before ibus-daemon disconnects the dbus
connection.
What do you think?

[Peng, 2011-04-27 01:13:44]

http://codereview.appspot.com/4440059/diff/1/bus/dbusimpl.c
File bus/dbusimpl.c (right):

http://codereview.appspot.com/4440059/diff/1/bus/dbusimpl.c#newcode585
bus/dbusimpl.c:585: g_dbus_connection_close (dconnection, NULL, NULL, NULL);
I am thinking, maybe we could just use ibus_object_destroy (connection) to
replace g_dbus_connection_close();

http://codereview.appspot.com/4440059/diff/1/bus/server.c
File bus/server.c (right):

http://codereview.appspot.com/4440059/diff/1/bus/server.c#newcode37
bus/server.c:37: void
static void

[fujiwara, 2011-04-27 02:55:36]

On 2011/04/27 01:13:44, Peng wrote:
> http://codereview.appspot.com/4440059/diff/1/bus/dbusimpl.c#newcode585
> bus/dbusimpl.c:585: g_dbus_connection_close (dconnection, NULL, NULL, NULL);
> I am thinking, maybe we could just use ibus_object_destroy (connection) to
> replace g_dbus_connection_close();


OK, done.

> http://codereview.appspot.com/4440059/diff/1/bus/server.c#newcode37
> bus/server.c:37: void
> static void

Done.

[Peng, 2011-04-27 11:38:58]

Lgtm