Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1504)

Issue 4438070: Update SK_API to support non-Windows DLLs.

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 6 months ago by evan
Modified:
13 years, 6 months ago
Reviewers:
agl, bsalomon, reed1
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Update SK_API to support non-Windows DLLs. On non-Windows platforms, use the visibility annotation to export API symbols.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -5 lines) Patch
M include/core/SkPreConfig.h View 1 chunk +9 lines, -5 lines 0 comments Download

Messages

Total messages: 6
evan
13 years, 6 months ago (2011-04-25 23:37:52 UTC) #1
reed1
How do I test this? Is there a tweak to our Makefile, or some other ...
13 years, 6 months ago (2011-04-26 11:38:53 UTC) #2
evan
On 2011/04/26 11:38:53, reed1 wrote: > How do I test this? Is there a tweak ...
13 years, 6 months ago (2011-04-26 16:45:14 UTC) #3
reed1
LGTM BWT - skia has a makefile that builds the library + a set of ...
13 years, 6 months ago (2011-04-26 19:05:41 UTC) #4
evan
Can you land this for me? Thanks for the note -- I have locally modified ...
13 years, 6 months ago (2011-04-26 19:42:13 UTC) #5
reed1
13 years, 6 months ago (2011-04-26 20:04:31 UTC) #6
Committed revision 1192.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b