Issue 4437062: Fix Python input context binding.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4437062: Fix Python input context binding. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years ago by Daiki Ueno

Modified:
12 years, 11 months ago

Reviewers:
shawn.p.huang, Peng

Base URL:
git@github.com:ibus/ibus.git@master

Visibility:
Public.

Description

Fix Python input context binding. Export "forward-key-event" and "delete-surrounding-text" signals to Python; clear __needs_surrounding_text property on "enabled" and "disabled" signals. BUG=none TEST=briefly tested, at least I don't see any regression

Patch Set 1 #

Patch Set 2 : add DeleteSurroundingText stub in iinputcontext.py #

Created: 13 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -1 line)			Patch
	M	ibus/inputcontext.py	View		3 chunks	+25 lines, -1 line	0 comments	Download
	M	ibus/interface/iinputcontext.py	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

Daiki Ueno

Someone pointed out that those signals are not exposed to Python: https://twitter.com/#!/iRi_E/status/60627003358986240 Also, needs_surrounding_text property ...

13 years ago (2011-04-21 08:20:48 UTC) #1

Daiki Ueno

Ah, sorry, it turned out that interface/iinputcontext.py should be modified as well. Since I left ...

13 years ago (2011-04-21 10:59:20 UTC) #2

Peng

On 2011/04/21 10:59:20, Daiki Ueno wrote: > Ah, sorry, it turned out that interface/iinputcontext.py should ...

12 years, 11 months ago (2011-06-06 13:31:11 UTC) #3

Daiki Ueno

On 2011/06/06 13:31:11, Peng wrote: > LGTM. Very sorry for the late reply. Thanks. Shall ...

12 years, 11 months ago (2011-06-08 01:15:15 UTC) #4

shawn.p.huang_gmail.com

12 years, 11 months ago (2011-06-08 14:22:32 UTC) #5

Done.

On Tue, Jun 7, 2011 at 9:15 PM,  <daiki.ueno@gmail.com> wrote:
> On 2011/06/06 13:31:11, Peng wrote:
>
>> LGTM. Very sorry for the late reply.
>
> Thanks.  Shall we also merge https://github.com/ibus/ibus/pull/2 ?
> Looks trivial and should be safe since no Python engine currently uses
> EngineBase#forward_key_event().
>
> http://codereview.appspot.com/4437062/
>

Expand All Messages | Collapse All Messages