Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(835)

Issue 4437055: remove static from recursive template definitions (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 6 months ago by reed1
Modified:
13 years, 1 month ago
Reviewers:
bsalomon
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M gpu/src/GrDrawTarget.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2
reed1
The linux build didn't like 'static' on the specialized function. The mac (at least on ...
13 years, 6 months ago (2011-04-19 15:17:31 UTC) #1
bsalomon
13 years, 6 months ago (2011-04-19 15:28:48 UTC) #2
LGTM

On Tue, Apr 19, 2011 at 11:17 AM, <reed@google.com> wrote:

> Reviewers: bsalomon,
>
> Message:
> The linux build didn't like 'static' on the specialized function. The
> mac (at least on my desktop) doesn't like it on the general function but
> not the specialized.
>
> If I remove it from both, both platforms seem to be happy.
>
>
>
> Please review this at http://codereview.appspot.com/4437055/
>
> Affected files:
>  M     gpu/src/GrDrawTarget.cpp
>
>
> Index: gpu/src/GrDrawTarget.cpp
> ===================================================================
> --- gpu/src/GrDrawTarget.cpp    (revision 1149)
> +++ gpu/src/GrDrawTarget.cpp    (working copy)
> @@ -22,7 +22,7 @@
>  // recursive helper for creating mask with all the tex coord bits set for
>  // one stage
>  template <int N>
> -static int stage_mask_recur(int stage) {
> +int stage_mask_recur(int stage) {
>     return GrDrawTarget::StageTexCoordVertexLayoutBit(stage, N) |
>            stage_mask_recur<N+1>(stage);
>  }
> @@ -43,7 +43,7 @@
>  // recursive helper for creating mask of with all bits set relevant to one
>  // texture coordinate index
>  template <int N>
> -static int tex_coord_mask_recur(int texCoordIdx) {
> +int tex_coord_mask_recur(int texCoordIdx) {
>     return GrDrawTarget::StageTexCoordVertexLayoutBit(N, texCoordIdx) |
>            tex_coord_mask_recur<N+1>(texCoordIdx);
>  }
>
>
>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b