Issue 4436057: Tag some more API headers with SK_API so they are exposed

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 8 months ago by evan

Modified:
13 years, 8 months ago

Reviewers:
agl, reed1

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Tag some more API headers with SK_API so they are exposed when doing a DLL build.

Created: 13 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -8 lines)			Patch
M	include/core/Sk64.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	include/core/SkColor.h	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	include/core/SkFontHost.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	include/core/SkMetaData.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	include/core/SkStream.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	include/core/SkThread_platform.h	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download

Total messages: 6

reed1

Curious, who are the external clients of SkFontHost? It was (originally) intended to just be ...

13 years, 8 months ago (2011-04-26 11:40:25 UTC) #2

evan

On 2011/04/26 11:40:25, reed1 wrote: > Curious, who are the external clients of SkFontHost? It ...

13 years, 8 months ago (2011-04-26 16:38:46 UTC) #3

evan

Sorry, I needed to modify two more headers to get a full Chrome build working. ...

13 years, 8 months ago (2011-04-26 19:44:02 UTC) #5

Committed revision 1193.