Keyboard Shortcuts
File
u
:
up to issue
m
:
publish + mail comments
M
:
edit review message
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
<Enter>
:
respond to / edit current comment
d
:
mark current comment as done
Issue
u
:
up to list of issues
m
:
publish + mail comments
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
#
:
close issue
Comment/message editing
<Ctrl>
+
s
or
<Ctrl>
+
Enter
:
save comment
<Esc>
:
cancel edit
Rietveld
Code Review Tool
Help
|
Bug tracker
|
Discussion group
|
Source code
|
Sign in
(1554)
Issues
Repositories
Search
Open Issues
|
Closed Issues
|
All Issues
|
Sign in
with your
Google Account
to create issues and add comments
Issue
4435082
: Add all ES2 supported glUniform functions. Add validation to GrGLInterface. (Closed)
Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 1 month ago by
bsalomon
Modified:
14 years, 1 month ago
Reviewers:
reed1
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.
Patch Set 1
#
Patch Set 2 : update unix/mac grglinterfaces
#
Patch Set 3 : actually upload unix version
#
Patch Set 4 : fix unix
#
Patch Set 5 : fix mac
#
Created:
14 years, 1 month ago
Download
[raw]
[tar.bz2]
Unified diffs
Side-by-side diffs
Delta from patch set
Stats
(
+354 lines, -27 lines
)
Patch
M
gpu/include/GrGLInterface.h
View
1
2
3
6 chunks
+50 lines, -14 lines
0 comments
Download
M
gpu/src/GrGLInterface.cpp
View
1
2
3
1 chunk
+243 lines, -0 lines
0 comments
Download
M
gpu/src/GrGpuFactory.cpp
View
1
2
3
1 chunk
+6 lines, -0 lines
0 comments
Download
M
gpu/src/mac/GrGLDefaultInterface_mac.cpp
View
1
2
3
4
1 chunk
+18 lines, -3 lines
0 comments
Download
M
gpu/src/unix/GrGLDefaultInterface_unix.cpp
View
1
2
3
2 chunks
+19 lines, -7 lines
0 comments
Download
M
gpu/src/win/GrGLDefaultInterface_win.cpp
View
1
2
3
2 chunks
+18 lines, -3 lines
0 comments
Download
Messages
Total messages: 4
Expand All Messages
|
Collapse All Messages
bsalomon
14 years, 1 month ago (2011-05-03 17:31:13 UTC)
#1
Sign in
to reply to this message.
bsalomon
This will require a chrome change. On 2011/05/03 17:31:13, bsalomon wrote:
14 years, 1 month ago (2011-05-03 17:31:29 UTC)
#2
This will require a chrome change. On 2011/05/03 17:31:13, bsalomon wrote:
Sign in
to reply to this message.
reed1
LGTM
14 years, 1 month ago (2011-05-03 17:32:47 UTC)
#3
LGTM
Sign in
to reply to this message.
bsalomon
closed with r1234
14 years, 1 month ago (2011-05-04 12:58:25 UTC)
#4
closed with r1234
Sign in
to reply to this message.
Expand All Messages
|
Collapse All Messages
Issue 4435082: Add all ES2 supported glUniform functions. Add validation to GrGLInterface. (Closed)
Created 14 years, 1 month ago by bsalomon
Modified 14 years, 1 month ago
Reviewers: reed1
Base URL: http://skia.googlecode.com/svn/trunk/
Comments: 0
Recent Issues
|
This issue
This is Rietveld
f62528b