Issue 4435060: Fix aligment bugs in preallocated stack space

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4435060: Fix aligment bugs in preallocated stack space (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 7 months ago by bsalomon

Modified:
13 years, 7 months ago

Reviewers:
reed1

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Created: 13 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+156 lines, -84 lines)			Patch
M	gpu/include/GrAllocator.h	View	1 2	3 chunks	+16 lines, -7 lines	0 comments	Download
M	gpu/include/GrClip.h	View	1 2	2 chunks	+2 lines, -1 line	0 comments	Download
M	gpu/include/GrInOrderDrawBuffer.h	View	1 2	1 chunk	+10 lines, -11 lines	0 comments	Download
M	gpu/include/GrTArray.h	View	1 2	3 chunks	+12 lines, -0 lines	0 comments	Download
A	gpu/include/GrTemplates.h	View	1 2	1 chunk	+108 lines, -0 lines	0 comments	Download
M	gpu/include/GrTypes.h	View		1 chunk	+0 lines, -57 lines	0 comments	Download
M	gpu/src/GrClip.cpp	View		1 chunk	+5 lines, -5 lines	0 comments	Download
M	gpu/src/GrInOrderDrawBuffer.cpp	View		1 chunk	+3 lines, -3 lines	0 comments	Download

Total messages: 3

bsalomon

updated with new name and a non-typed version of the stack helper

13 years, 7 months ago (2011-04-20 15:21:01 UTC) #2

(Got a verbal LGTM from Mike).

Closed with r1162.