Keyboard Shortcuts
File
u
:
up to issue
m
:
publish + mail comments
M
:
edit review message
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
<Enter>
:
respond to / edit current comment
d
:
mark current comment as done
Issue
u
:
up to list of issues
m
:
publish + mail comments
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
#
:
close issue
Comment/message editing
<Ctrl>
+
s
or
<Ctrl>
+
Enter
:
save comment
<Esc>
:
cancel edit
Rietveld
Code Review Tool
Help
|
Bug tracker
|
Discussion group
|
Source code
|
Sign in
(209)
Issues
Repositories
Search
Open Issues
|
Closed Issues
|
All Issues
|
Sign in
with your
Google Account
to create issues and add comments
Issue
4433069
: Bunch of style fixes to meet PEP8. (Closed)
Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years, 1 month ago by
tyoshino (chromium.org)
Modified:
15 years ago
Reviewers:
Takashi Toyoshima
,
Yuta Kitamura
CC:
pywebsocket-reviews_googlegroups.com
Base URL:
http://pywebsocket.googlecode.com/svn/
Visibility:
Public.
Description
Bunch of style fixes to meet PEP8.
Patch Set 1
#
Patch Set 2 : ''
#
Patch Set 3 : ''
#
Patch Set 4 : ''
#
Patch Set 5 : ''
#
Created:
15 years, 1 month ago
Download
[raw]
[tar.bz2]
Unified diffs
Side-by-side diffs
Delta from patch set
Stats
(
+15 lines, -7 lines
)
Patch
M
trunk/src/mod_pywebsocket/_stream_hixie75.py
View
1
2
3
1 chunk
+2 lines, -1 line
0 comments
Download
M
trunk/src/mod_pywebsocket/headerparserhandler.py
View
1
2
3
5 chunks
+9 lines, -5 lines
0 comments
Download
M
trunk/src/mod_pywebsocket/msgutil.py
View
1
2
3
4 chunks
+4 lines, -1 line
0 comments
Download
Messages
Total messages: 4
Expand All Messages
|
Collapse All Messages
tyoshino (chromium.org)
15 years, 1 month ago (2011-05-13 09:57:48 UTC)
#1
Sign in
to reply to this message.
Takashi Toyoshima
LGTM.
15 years ago (2011-05-16 08:38:59 UTC)
#2
LGTM.
Sign in
to reply to this message.
Yuta Kitamura
LGTM.
15 years ago (2011-05-16 12:36:30 UTC)
#3
LGTM.
Sign in
to reply to this message.
Yuta Kitamura
LGTM.
15 years ago (2011-05-16 12:36:30 UTC)
#4
LGTM.
Sign in
to reply to this message.
Expand All Messages
|
Collapse All Messages
Issue 4433069: Bunch of style fixes to meet PEP8. (Closed)
Created 15 years, 1 month ago by tyoshino (chromium.org)
Modified 15 years ago
Reviewers: Yuta Kitamura, Takashi Toyoshima
Base URL: http://pywebsocket.googlecode.com/svn/
Comments: 0
Recent Issues
|
This issue
This is Rietveld
f62528b